diff mbox series

[4.14] phonet: refcount leak in pep_sock_accep

Message ID 20220107105332.61347-1-aayush.a.agarwal@oracle.com
State New
Headers show
Series [4.14] phonet: refcount leak in pep_sock_accep | expand

Commit Message

Aayush Agarwal Jan. 7, 2022, 10:53 a.m. UTC 
From: Hangyu Hua <hbh25y@gmail.com>

commit bcd0f9335332 ("phonet: refcount leak in pep_sock_accep")
upstream.

sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Aayush Agarwal <aayush.a.agarwal@oracle.com>
---
 net/phonet/pep.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/net/phonet/pep.c b/net/phonet/pep.c
index b0d958cd1823..4c4a8a42ee88 100644
--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -881,6 +881,7 @@  static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,
 
 	err = pep_accept_conn(newsk, skb);
 	if (err) {
+		__sock_put(sk);
 		sock_put(newsk);
 		newsk = NULL;
 		goto drop;