| Message ID | 20220112174612.10773-20-biju.das.jz@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add RZ/G2L Display support | expand |
On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > index 990e9c1dbc43..b27ee23d2b29 100644 > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > @@ -19,6 +19,7 @@ properties: > enum: > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > reg: > maxItems: 1 > @@ -27,7 +28,8 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 You have to define what each one is once you have more than 1. > > power-domains: > maxItems: 1 > -- > 2.17.1 > >
Hi Rob, Thanks for the review. > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > RZ/{G2L,V2L} VSPD bindings > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > index 990e9c1dbc43..b27ee23d2b29 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > @@ -19,6 +19,7 @@ properties: > > enum: > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > > > reg: > > maxItems: 1 > > @@ -27,7 +28,8 @@ properties: > > maxItems: 1 > > > > clocks: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 3 > > You have to define what each one is once you have more than 1. Agreed, Will define each clocks. Regards, Biju > > > > > power-domains: > > maxItems: 1 > > -- > > 2.17.1 > > > >
Hi Biju, On Sat, Jan 22, 2022 at 11:23:32AM +0000, Biju Das wrote: > > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > > RZ/{G2L,V2L} VSPD bindings > > > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > index 990e9c1dbc43..b27ee23d2b29 100644 > > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > @@ -19,6 +19,7 @@ properties: > > > enum: > > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L The commit message should explain why a new device-specific compatible value is needed. > > > > > > reg: > > > maxItems: 1 > > > @@ -27,7 +28,8 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > - maxItems: 1 > > > + minItems: 1 > > > + maxItems: 3 > > > > You have to define what each one is once you have more than 1. > > Agreed, Will define each clocks. This should also be conditioned by the compatible string, to have maxItems set to 1 for renesas,vsp1 and renesas,vsp2, and 3 for renesas,vsp2-r9a07g044. > > > power-domains: > > > maxItems: 1
Hi Laurent, Thanks for the feedback. > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: Document > RZ/{G2L,V2L} VSPD bindings > > Hi Biju, > > On Sat, Jan 22, 2022 at 11:23:32AM +0000, Biju Das wrote: > > > Subject: Re: [RFC 19/28] media: dt-bindings: media: renesas,vsp1: > > > Document RZ/{G2L,V2L} VSPD bindings > > > > > > On Wed, Jan 12, 2022 at 05:46:03PM +0000, Biju Das wrote: > > > > Document VSPD found in RZ/G2L and RZ/V2L family SoC's. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > --- > > > > Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 > > > > +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > index 990e9c1dbc43..b27ee23d2b29 100644 > > > > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml > > > > @@ -19,6 +19,7 @@ properties: > > > > enum: > > > > - renesas,vsp1 # R-Car Gen2 and RZ/G1 > > > > - renesas,vsp2 # R-Car Gen3 and RZ/G2 > > > > + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L > > The commit message should explain why a new device-specific compatible > value is needed. OK. Will add this in next version. Basically It does not have version register compared to other SoC's supported by this driver. > > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -27,7 +28,8 @@ properties: > > > > maxItems: 1 > > > > > > > > clocks: > > > > - maxItems: 1 > > > > + minItems: 1 > > > > + maxItems: 3 > > > > > > You have to define what each one is once you have more than 1. > > > > Agreed, Will define each clocks. > > This should also be conditioned by the compatible string, to have maxItems > set to 1 for renesas,vsp1 and renesas,vsp2, and 3 for renesas,vsp2- > r9a07g044. Agreed. Regards, Biju > > > > > power-domains: > > > > maxItems: 1 > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml index 990e9c1dbc43..b27ee23d2b29 100644 --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml @@ -19,6 +19,7 @@ properties: enum: - renesas,vsp1 # R-Car Gen2 and RZ/G1 - renesas,vsp2 # R-Car Gen3 and RZ/G2 + - renesas,vsp2-r9a07g044 # RZ/G2L and RZ/V2L reg: maxItems: 1 @@ -27,7 +28,8 @@ properties: maxItems: 1 clocks: - maxItems: 1 + minItems: 1 + maxItems: 3 power-domains: maxItems: 1
Document VSPD found in RZ/G2L and RZ/V2L family SoC's. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- Documentation/devicetree/bindings/media/renesas,vsp1.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)