| Message ID | 20220111174805.223732-2-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | mfd/extcon/regulators: max77843: add dtschema/bindings | expand |
On Tue, 11 Jan 2022 18:48:01 +0100, Krzysztof Kozlowski wrote: > The newly introduced dtschema for MAX77843 MUIC require the children to > have proper naming and a port@0 property. > > This should not have actual impact on MFD children driver binding, > because the max77843 MFD driver uses compatibles. The port@0 is > disabled to avoid any impact. > > [...] Applied, thanks! [1/5] arm64: dts: exynos: Align MAX77843 nodes with dtschema on TM2 commit: 7638d3c945beb6c781acf5dd0a78e04c76f1c32f Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index cbcc01a66aab..03f7c9acaacb 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -858,10 +858,10 @@ pmic@66 { interrupts = <5 IRQ_TYPE_EDGE_FALLING>; reg = <0x66>; - muic: max77843-muic { + muic: extcon { compatible = "maxim,max77843-muic"; - musb_con: musb-connector { + musb_con: connector { compatible = "samsung,usb-connector-11pin", "usb-b-connector"; label = "micro-USB"; @@ -871,6 +871,17 @@ ports { #address-cells = <1>; #size-cells = <0>; + port@0 { + /* + * TODO: The DTS this is based on does not have + * port@0 which is a required property. The ports + * look incomplete and need fixing. + * Add a disabled port just to satisfy dtschema. + */ + reg = <0>; + status = "disabled"; + }; + port@3 { reg = <3>; musb_con_to_mhl: endpoint { @@ -910,7 +921,7 @@ charger_reg: CHARGER { }; }; - haptic: max77843-haptic { + haptic: motor-driver { compatible = "maxim,max77843-haptic"; haptic-supply = <&ldo38_reg>; pwms = <&pwm 0 33670 0>;
The newly introduced dtschema for MAX77843 MUIC require the children to have proper naming and a port@0 property. This should not have actual impact on MFD children driver binding, because the max77843 MFD driver uses compatibles. The port@0 is disabled to avoid any impact. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Please kindly test or even better - fix the DTS and extcon driver. --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)