| Message ID | 20220113164233.1.I19f60014e9be4b9dda4d66b5d56ef3d9600b6e10@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: Introduce herobrine-rev1 | expand |
Quoting Douglas Anderson (2022-01-13 16:43:00) > When processing sc7280 device trees, I can see: > > Warning (simple_bus_reg): /soc@0/gmu@3d69000: > simple-bus unit address format error, expected "3d6a000" > > There's a clear typo in the node name. Fix it. > > Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org> BTW, gmu isn't a "standard" node name so might be worth replacing that with something else but I have no idea what. Maybe "firmware" or "power-controller"?
Hi, On Thu, Jan 13, 2022 at 10:08 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-01-13 16:43:00) > > When processing sc7280 device trees, I can see: > > > > Warning (simple_bus_reg): /soc@0/gmu@3d69000: > > simple-bus unit address format error, expected "3d6a000" > > > > There's a clear typo in the node name. Fix it. > > > > Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks for all the reviews! > BTW, gmu isn't a "standard" node name so might be worth replacing that > with something else but I have no idea what. Maybe "firmware" or > "power-controller"? "gmu" matches what's in the "example" in Documentation/devicetree/bindings/display/msm/gmu.yaml. That was blessed by Rob Herring. If you think it should be something different, perhaps post a patch changing the example in the bindings? -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 937c2e0e93eb..eab7a8505053 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -1790,7 +1790,7 @@ opp-550000000 { }; }; - gmu: gmu@3d69000 { + gmu: gmu@3d6a000 { compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu"; reg = <0 0x03d6a000 0 0x34000>, <0 0x3de0000 0 0x10000>,
When processing sc7280 device trees, I can see: Warning (simple_bus_reg): /soc@0/gmu@3d69000: simple-bus unit address format error, expected "3d6a000" There's a clear typo in the node name. Fix it. Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)