diff mbox series

regulator: qcom_smd: fix for_each_child.cocci warnings

Message ID alpine.DEB.2.22.394.2201151210170.3051@hadrien
State New
Headers show
Series regulator: qcom_smd: fix for_each_child.cocci warnings | expand

Commit Message

Julia Lawall Jan. 15, 2022, 11:11 a.m. UTC 
From: kernel test robot <lkp@intel.com>

drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 14e2976fbabd ("regulator: qcom_smd: Align probe function with rpmh-regulator")
CC: Konrad Dybcio <konrad.dybcio@somainline.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   112450df61b7373529b0fe4c122ad13b89d80a8a
commit: 14e2976fbabdacb01335d7f91eeebbc89c67ddb1 regulator: qcom_smd: Align probe function with rpmh-regulator
:::::: branch date: 13 hours ago
:::::: commit date: 9 days ago

 qcom_smd-regulator.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Mark Brown Jan. 25, 2022, 10:20 a.m. UTC | #1 
On Sat, 15 Jan 2022 12:11:38 +0100 (CET), Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321.
> 
> 
> Semantic patch information:
>  False positives can be due to function calls within the for_each
>  loop that may encapsulate an of_node_put.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom_smd: fix for_each_child.cocci warnings
      commit: 6390d42c21efff0b4c10956a38e341f4e84ecd3d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -1317,8 +1317,10 @@  static int rpm_reg_probe(struct platform

 	for_each_available_child_of_node(dev->of_node, node) {
 		vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
-		if (!vreg)
+		if (!vreg) {
+			of_node_put(node);
 			return -ENOMEM;
+		}

 		ret = rpm_regulator_init_vreg(vreg, dev, node, rpm, vreg_data);