| Message ID | 20220117112109.215695-1-hdegoede@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] leds: simatic-ipc-leds: Make simatic_ipc_led_mem_res static | expand |
LGTM Am Mon, 17 Jan 2022 12:21:08 +0100 schrieb Hans de Goede <hdegoede@redhat.com>: > simatic_ipc_led_mem_res is not used outside of the driver, make it > static. > > Cc: Henning Schild <henning.schild@siemens.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/leds/simple/simatic-ipc-leds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/simple/simatic-ipc-leds.c > b/drivers/leds/simple/simatic-ipc-leds.c index > ff2c96e73241..179110448659 100644 --- > a/drivers/leds/simple/simatic-ipc-leds.c +++ > b/drivers/leds/simple/simatic-ipc-leds.c @@ -39,7 +39,7 @@ static > struct simatic_ipc_led simatic_ipc_leds_io[] = { }; > > /* the actual start will be discovered with PCI, 0 is a placeholder > */ -struct resource simatic_ipc_led_mem_res = DEFINE_RES_MEM_NAMED(0, > SZ_4K, KBUILD_MODNAME); +static struct resource > simatic_ipc_led_mem_res = DEFINE_RES_MEM_NAMED(0, SZ_4K, > KBUILD_MODNAME); static void *simatic_ipc_led_memory; >
diff --git a/drivers/leds/simple/simatic-ipc-leds.c b/drivers/leds/simple/simatic-ipc-leds.c index ff2c96e73241..179110448659 100644 --- a/drivers/leds/simple/simatic-ipc-leds.c +++ b/drivers/leds/simple/simatic-ipc-leds.c @@ -39,7 +39,7 @@ static struct simatic_ipc_led simatic_ipc_leds_io[] = { }; /* the actual start will be discovered with PCI, 0 is a placeholder */ -struct resource simatic_ipc_led_mem_res = DEFINE_RES_MEM_NAMED(0, SZ_4K, KBUILD_MODNAME); +static struct resource simatic_ipc_led_mem_res = DEFINE_RES_MEM_NAMED(0, SZ_4K, KBUILD_MODNAME); static void *simatic_ipc_led_memory;
simatic_ipc_led_mem_res is not used outside of the driver, make it static. Cc: Henning Schild <henning.schild@siemens.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/leds/simple/simatic-ipc-leds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)