| Message ID | 20150911124045.GA16833@arm.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Sep 11, 2015 at 01:40:45PM +0100, Will Deacon wrote: > On Fri, Sep 11, 2015 at 01:01:51PM +0100, Mark Brown wrote: > > On Fri, Sep 11, 2015 at 11:01:35AM +0100, Build bot for Mark Brown wrote: > > > > > arm64-allmodconfig > > > ../drivers/firmware/qcom_scm-32.c:196:4: error: expected string literal before '__asmeq' > > > ../drivers/firmware/qcom_scm-32.c:221:2: error: implicit declaration of function 'secure_flush_area' [-Werror=implicit-function-declaration] > > > ../drivers/firmware/qcom_scm-32.c:239:2: error: implicit declaration of function 'outer_inv_range' [-Werror=implicit-function-declaration] > > > ../drivers/firmware/qcom_scm-32.c:331:4: error: expected string literal before '__asmeq' > > > ../drivers/firmware/qcom_scm-32.c:361:4: error: expected string literal before '__asmeq' > > > > Today's mainline fails to build on arm64 due to the above, introduced by > > efaa6e266ba (firmware: qcom_scm-32: replace open-coded call to > > __cpuc_flush_dcache_area()) which introduces a call to > > secure_flush_area() which isn't defined on arm64. This does not happen > > in -next as 626ffb400e1e781 (firmware: qcom: scm: Add function stubs for > > ARM64) which fixes this and IIRC other issues on arm64 - what is the > > plan for getting that change into mainline? > > There's no way in hell that driver is going to build for arm64, so I'd > suggest something like the following until it's sorted out. The below doesn't help. QCOM_SCM can only be enabled if something selects it (it has no prompt). Somewhere, a new commit selecting this option from ARM64 builds has appeared. Modifying the dependencies of this option in the way you're doing will cause a Kconfig warning, because the dependencies of a selected option are not met. > --->8 > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 99c69a3205c4..2f51e249829f 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -134,7 +134,7 @@ config ISCSI_IBFT > > config QCOM_SCM > bool > - depends on ARM || ARM64 > + depends on ARM > > source "drivers/firmware/broadcom/Kconfig" > source "drivers/firmware/google/Kconfig" >
On Fri, Sep 11, 2015 at 02:00:06PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 11, 2015 at 01:40:45PM +0100, Will Deacon wrote: > > On Fri, Sep 11, 2015 at 01:01:51PM +0100, Mark Brown wrote: > > > On Fri, Sep 11, 2015 at 11:01:35AM +0100, Build bot for Mark Brown wrote: > > > > > > > arm64-allmodconfig > > > > ../drivers/firmware/qcom_scm-32.c:196:4: error: expected string literal before '__asmeq' > > > > ../drivers/firmware/qcom_scm-32.c:221:2: error: implicit declaration of function 'secure_flush_area' [-Werror=implicit-function-declaration] > > > > ../drivers/firmware/qcom_scm-32.c:239:2: error: implicit declaration of function 'outer_inv_range' [-Werror=implicit-function-declaration] > > > > ../drivers/firmware/qcom_scm-32.c:331:4: error: expected string literal before '__asmeq' > > > > ../drivers/firmware/qcom_scm-32.c:361:4: error: expected string literal before '__asmeq' > > > > > > Today's mainline fails to build on arm64 due to the above, introduced by > > > efaa6e266ba (firmware: qcom_scm-32: replace open-coded call to > > > __cpuc_flush_dcache_area()) which introduces a call to > > > secure_flush_area() which isn't defined on arm64. This does not happen > > > in -next as 626ffb400e1e781 (firmware: qcom: scm: Add function stubs for > > > ARM64) which fixes this and IIRC other issues on arm64 - what is the > > > plan for getting that change into mainline? > > > > There's no way in hell that driver is going to build for arm64, so I'd > > suggest something like the following until it's sorted out. > > The below doesn't help. QCOM_SCM can only be enabled if something > selects it (it has no prompt). Somewhere, a new commit selecting > this option from ARM64 builds has appeared. So it's one of these guys: drivers/gpu/drm/msm/Kconfig: select QCOM_SCM drivers/soc/qcom/Kconfig: select QCOM_SCM The latter has a "depends on !ARM64", so I guess it's the former (which depends on ARCH_QCOM and is selectable on arm64). > Modifying the dependencies of this option in the way you're doing will > cause a Kconfig warning, because the dependencies of a selected option > are not met. Damn. I wonder why the dependency is there in the first place if it's just selected by another symbol? Will
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 99c69a3205c4..2f51e249829f 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -134,7 +134,7 @@ config ISCSI_IBFT config QCOM_SCM bool - depends on ARM || ARM64 + depends on ARM source "drivers/firmware/broadcom/Kconfig" source "drivers/firmware/google/Kconfig"