| Message ID | 1442386021-5113-2-git-send-email-zhaoyang.huang@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 16/09/15 07:47, Zhaoyang Huang wrote: > add property of "linux,wakeup" to let the driver know > if the device should work as wakeup source > I think I made it *pretty clear multiple times by now* that PL011 is *not a wakeup source* on Juno. I have no idea what you are testing, it simply can't wakeup the system for suspended state. So I seriously doubt now what is that you are testing. So, this patch clearly gets NACK. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Zhaouyang, On 16/09/15 09:53, Zhaoyang Huang wrote: > Hi Sudeep, Please stop top-posting, I have told you many times now in private. > Sorry for the confusions I made. I am testing the suspend to idle on > juno, which is similar to suspend to ram, while the difference is the > cpu will go into idle itself(you can refer the function freeze_enter()) > instead of running cpu_suspend finally. I find that the pl011 can wakeup > the system by receiving from the tty. > No, it shouldn't be allowed to be configured as wakeup if it can't wakeup from S2R. So please stop sending this patch. I need to see real use case for PL011 as a wakeup source. Also, if we go by your definition, we can make any interrupt as wakeup source. You need to understand that we hardware support for an interrupt to be a wakeup irq. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/serial/pl011.txt b/Documentation/devicetree/bindings/serial/pl011.txt index cbae3d9..609e8e9 100644 --- a/Documentation/devicetree/bindings/serial/pl011.txt +++ b/Documentation/devicetree/bindings/serial/pl011.txt @@ -35,7 +35,8 @@ Optional properties: - poll-timeout-ms: Poll timeout when auto-poll is set, default 3000ms. - +- linux,wakeup: + set the pl011 work as wakeup source for suspend to ram/idle See also bindings/arm/primecell.txt Example: diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi index a3d5a77..f7bb150 100644 --- a/arch/arm64/boot/dts/arm/juno-base.dtsi +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi @@ -152,6 +152,7 @@ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; clocks = <&soc_uartclk>, <&soc_refclk100mhz>; clock-names = "uartclk", "apb_pclk"; + linux,wakeup; }; i2c@7ffa0000 {
add property of "linux,wakeup" to let the driver know if the device should work as wakeup source Signed-off-by: Zhaoyang Huang <zhaoyang.huang@linaro.org> --- Documentation/devicetree/bindings/serial/pl011.txt | 3 ++- arch/arm64/boot/dts/arm/juno-base.dtsi | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)