| Message ID | 20220127221710.165733-1-dlatypov@google.com |
|---|---|
| State | Accepted |
| Commit | de4d73b16d5d9c3e5d03a66046e5410e1e74f903 |
| Headers | show |
| Series | kunit: fix missing f in f-string in run_checks.py | expand |
On Fri, Jan 28, 2022 at 6:17 AM Daniel Latypov <dlatypov@google.com> wrote: > > We're missing the `f` prefix to have python do string interpolation, so > we'd never end up printing what the actual "unexpected" error is. > > Fixes: ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes") > Signed-off-by: Daniel Latypov <dlatypov@google.com> > --- Looks good! Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > tools/testing/kunit/run_checks.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/kunit/run_checks.py b/tools/testing/kunit/run_checks.py > index 4f32133ed77c..13d854afca9d 100755 > --- a/tools/testing/kunit/run_checks.py > +++ b/tools/testing/kunit/run_checks.py > @@ -61,7 +61,7 @@ def main(argv: Sequence[str]) -> None: > elif isinstance(ex, subprocess.CalledProcessError): > print(f'{name}: FAILED') > else: > - print('{name}: unexpected exception: {ex}') > + print(f'{name}: unexpected exception: {ex}') > continue > > output = ex.output > > base-commit: 6125a5c70acddd9fc1fb7329047a254c74d0173c > -- > 2.35.0.rc2.247.g8bbb082509-goog >
On Thu, Jan 27, 2022 at 5:17 PM Daniel Latypov <dlatypov@google.com> wrote: > > We're missing the `f` prefix to have python do string interpolation, so > we'd never end up printing what the actual "unexpected" error is. > > Fixes: ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes") > Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
diff --git a/tools/testing/kunit/run_checks.py b/tools/testing/kunit/run_checks.py index 4f32133ed77c..13d854afca9d 100755 --- a/tools/testing/kunit/run_checks.py +++ b/tools/testing/kunit/run_checks.py @@ -61,7 +61,7 @@ def main(argv: Sequence[str]) -> None: elif isinstance(ex, subprocess.CalledProcessError): print(f'{name}: FAILED') else: - print('{name}: unexpected exception: {ex}') + print(f'{name}: unexpected exception: {ex}') continue output = ex.output
We're missing the `f` prefix to have python do string interpolation, so we'd never end up printing what the actual "unexpected" error is. Fixes: ee92ed38364e ("kunit: add run_checks.py script to validate kunit changes") Signed-off-by: Daniel Latypov <dlatypov@google.com> --- tools/testing/kunit/run_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 6125a5c70acddd9fc1fb7329047a254c74d0173c