diff mbox series

[v2,1/5] DFU: Do not copy the entity name over the buffer size

Message ID 164359754070.280839.249007223441412046.stgit@localhost
State Accepted
Commit d8ae90a8d47da2f22041bf9f6fd6d42a598f44ee
Headers show
Series DFU: Update dfu_alt_info parser etc. | expand

Commit Message

Masami Hiramatsu Jan. 31, 2022, 2:52 a.m. UTC 
Use strlcpy() instead of strcpy() to prevent copying the
entity name over the name buffer size.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
---
 drivers/dfu/dfu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Feb. 11, 2022, 5:06 p.m. UTC | #1 
On Mon, Jan 31, 2022 at 11:52:20AM +0900, Masami Hiramatsu wrote:

> Use strlcpy() instead of strcpy() to prevent copying the
> entity name over the name buffer size.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index af3975925a..66c41b5e76 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -503,7 +503,7 @@  static int dfu_fill_entity(struct dfu_entity *dfu, char *s, int alt,
 
 	debug("%s: %s interface: %s dev: %s\n", __func__, s, interface, devstr);
 	st = strsep(&s, " ");
-	strcpy(dfu->name, st);
+	strlcpy(dfu->name, st, DFU_NAME_SIZE);
 
 	dfu->alt = alt;
 	dfu->max_buf_size = 0;