diff mbox series

[BlueZ] gdbus: Emit InterfacesAdded of parents objects first

Message ID 20220204013620.2465024-1-luiz.dentz@gmail.com
State New
Headers show
Series [BlueZ] gdbus: Emit InterfacesAdded of parents objects first | expand

Commit Message

Luiz Augusto von Dentz Feb. 4, 2022, 1:36 a.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes InterfacesAdded respect the object hierarchy in case its
parent has pending interfaces to be added.

Fixes: https://github.com/bluez/bluez/issues/284
---
 gdbus/object.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox series

Patch

diff --git a/gdbus/object.c b/gdbus/object.c
index 50a8b4ff1..7232c2986 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -551,6 +551,12 @@  static void emit_interfaces_added(struct generic_data *data)
 	if (root == NULL || data == root)
 		return;
 
+	/* Emit InterfacesAdded on the parent first so it appears first on the
+	 * bus as chield objects may point to it.
+	 */
+	if (data->parent && data->parent->added)
+		emit_interfaces_added(data->parent);
+
 	signal = dbus_message_new_signal(root->path,
 					DBUS_INTERFACE_OBJECT_MANAGER,
 					"InterfacesAdded");