| Message ID | 20220204095914.5678-1-povik+lin@cutebit.org |
|---|---|
| State | Accepted |
| Commit | 19e138e43a0820bb4dbf8fb5c7691f82e9221f2b |
| Headers | show |
| Series | [v2] i2c: pasemi: Drop I2C classes from platform driver variant | expand |
On Fri, Feb 4, 2022, at 10:59, Martin Povišer wrote: > Drop I2C device-probing classes from platform variant of the PASemi > controller as it is only used on platforms where I2C devices should > be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not > raised as up to this point no devices relied on the old behavior.) > > Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver") > Signed-off-by: Martin Povišer <povik+lin@cutebit.org> Reviewed-by: Sven Peter <sven@svenpeter.dev>
On Fri, Feb 04, 2022 at 10:59:14AM +0100, Martin Povišer wrote: > Drop I2C device-probing classes from platform variant of the PASemi > controller as it is only used on platforms where I2C devices should > be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not > raised as up to this point no devices relied on the old behavior.) > > Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver") > Signed-off-by: Martin Povišer <povik+lin@cutebit.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-pasemi-core.c b/drivers/i2c/busses/i2c-pasemi-core.c index 4e161a4089d8..7728c8460dc0 100644 --- a/drivers/i2c/busses/i2c-pasemi-core.c +++ b/drivers/i2c/busses/i2c-pasemi-core.c @@ -333,7 +333,6 @@ int pasemi_i2c_common_probe(struct pasemi_smbus *smbus) smbus->adapter.owner = THIS_MODULE; snprintf(smbus->adapter.name, sizeof(smbus->adapter.name), "PA Semi SMBus adapter (%s)", dev_name(smbus->dev)); - smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD; smbus->adapter.algo = &smbus_algorithm; smbus->adapter.algo_data = smbus; diff --git a/drivers/i2c/busses/i2c-pasemi-pci.c b/drivers/i2c/busses/i2c-pasemi-pci.c index 1ab1f28744fb..cfc89e04eb94 100644 --- a/drivers/i2c/busses/i2c-pasemi-pci.c +++ b/drivers/i2c/busses/i2c-pasemi-pci.c @@ -56,6 +56,7 @@ static int pasemi_smb_pci_probe(struct pci_dev *dev, if (!smbus->ioaddr) return -EBUSY; + smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD; error = pasemi_i2c_common_probe(smbus); if (error) return error;
Drop I2C device-probing classes from platform variant of the PASemi controller as it is only used on platforms where I2C devices should be instantiated in devicetree. (The I2C_CLASS_DEPRECATED flag is not raised as up to this point no devices relied on the old behavior.) Fixes: d88ae2932df0 ("i2c: pasemi: Add Apple platform driver") Signed-off-by: Martin Povišer <povik+lin@cutebit.org> --- I am sending v2 as some people got their copy in v1 encrypted with their WKD keys (by accident). I changed email provider since. drivers/i2c/busses/i2c-pasemi-core.c | 1 - drivers/i2c/busses/i2c-pasemi-pci.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)