diff mbox series

[3/3] mmc-utils: Display STROBE_SUPPORT when printing EXT_CSD

Message ID 20220205205647.7677-3-marius@FreeBSD.org
State New
Headers show
Series [1/3] mmc-utils: manpage: Document -c option for partitioning commands | expand

Commit Message

Marius Strobl Feb. 5, 2022, 8:56 p.m. UTC 
Support for Enhanced Strobe mode introduced in eMMC 5.1 JESD84-B51
can be determined via EXT_CSD[184]. Along with the identification of
HS400 data rates added in commit 3969aa4804ed ("mmc_cmds: add HS400
data rates"), this allows to differentiate support for HS400/HS400ES.

Signed-off-by: Marius Strobl <marius@FreeBSD.org>
---
 mmc_cmds.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Avri Altman Feb. 6, 2022, 7:49 a.m. UTC | #1 
> Support for Enhanced Strobe mode introduced in eMMC 5.1 JESD84-B51 can be
> determined via EXT_CSD[184]. Along with the identification of
> HS400 data rates added in commit 3969aa4804ed ("mmc_cmds: add HS400 data
> rates"), this allows to differentiate support for HS400/HS400ES.
> 
> Signed-off-by: Marius Strobl <marius@FreeBSD.org>
Looks good to me.

Thanks,
Avri

> ---
>  mmc_cmds.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mmc_cmds.c b/mmc_cmds.c
> index f024079..508ddad 100644
> --- a/mmc_cmds.c
> +++ b/mmc_cmds.c
> @@ -1628,6 +1628,9 @@ int do_read_extcsd(int nargs, char **argv)
>         printf("Power class [POWER_CLASS: 0x%02x]\n", ext_csd[187]);
>         printf("High-speed interface timing [HS_TIMING: 0x%02x]\n",
>                 ext_csd[185]);
> +       if (ext_csd_rev >= 8)
> +               printf("Enhanced Strobe mode [STROBE_SUPPORT: 0x%02x]\n",
> +                       ext_csd[184]);
>         /* bus_width: ext_csd[183] not readable */
>         printf("Erased memory content [ERASED_MEM_CONT: 0x%02x]\n",
>                 ext_csd[181]);
> --
> 2.31.1
diff mbox series

Patch

diff --git a/mmc_cmds.c b/mmc_cmds.c
index f024079..508ddad 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1628,6 +1628,9 @@  int do_read_extcsd(int nargs, char **argv)
 	printf("Power class [POWER_CLASS: 0x%02x]\n", ext_csd[187]);
 	printf("High-speed interface timing [HS_TIMING: 0x%02x]\n",
 		ext_csd[185]);
+	if (ext_csd_rev >= 8)
+		printf("Enhanced Strobe mode [STROBE_SUPPORT: 0x%02x]\n",
+			ext_csd[184]);
 	/* bus_width: ext_csd[183] not readable */
 	printf("Erased memory content [ERASED_MEM_CONT: 0x%02x]\n",
 		ext_csd[181]);