| Message ID | 1443199123-13979-1-git-send-email-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 79ae6bb15945f9b7f3e91db3d68f1b77c4b1451c |
| Headers | show |
On 09/25/15 09:38, Lee Jones wrote: > This patch solves: > > on x86_64: > > when CONFIG_ACPI is not enabled: > > ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe': > ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2: > error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration] > status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); > ^ > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Works for me. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index c69bb70..744cb80 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -914,6 +914,7 @@ config PVPANIC > > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > + depends on ACPI > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication >
On Fri, Sep 25, 2015 at 06:53:56PM -0700, Randy Dunlap wrote: > On 09/25/15 09:38, Lee Jones wrote: > > This patch solves: > > > > on x86_64: > > > > when CONFIG_ACPI is not enabled: > > > > ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe': > > ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2: > > error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration] > > status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); > > ^ > > > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Works for me. Thanks. > > Acked-by: Randy Dunlap <rdunlap@infradead.org> Lee, Since this appears to be the result of a patch applied to the mfd tree, would you like to pick up this patch? Acked-by: Darren Hart <dvhart@linux.intel.com>
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index c69bb70..744cb80 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -914,6 +914,7 @@ config PVPANIC config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" + depends on ACPI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communication
This patch solves: on x86_64: when CONFIG_ACPI is not enabled: ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe': ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2: error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration] status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); ^ Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)