[v3,5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards

The node name of Ethernet controller should be "ethernet" instead of
"usbether"

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 4 ++--
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 8 ++++----
 arch/arm/boot/dts/exynos5410-odroidxu.dts       | 4 ++--
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 6 +++---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 6 +++---
 5 files changed, 14 insertions(+), 14 deletions(-)

On 15.02.2022 09:09:34, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether"
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 4 ++--
>  arch/arm/boot/dts/exynos4412-odroidx.dts        | 8 ++++----
>  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 4 ++--
>  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 6 +++---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 6 +++---
>  5 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> index efaf7533e84f..36c369c42b77 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> @@ -119,8 +119,8 @@ &ehci {
>  	phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
>  	phy-names = "hsic0", "hsic1";
>  
> -	ethernet: usbether@2 {
> -		compatible = "usb0424,9730";
> +	ethernet: ethernet@2 {
> +		compatible = "usb424,9730";

The change of the compatible is not mentioned in the patch description.
Is this intentional?

Marc

> > > -	ethernet: usbether@2 {
> > > -		compatible = "usb0424,9730";
> > > +	ethernet: ethernet@2 {
> > > +		compatible = "usb424,9730";
> > 
> > The change of the compatible is not mentioned in the patch description.
> > Is this intentional?
> 
> No, I forgot to mentione it. According to the USB schema 0 should be
> removed. So, this compatible was incorrect as well. With leading zero
> present yaml schema was not able to detect and validate this node.

Does the current code not actually care about a leading 0? It will
match with or without it? It would be good to mention that as well in
the commit message, otherwise somebody like me is going to ask if this
breaks backwards compatibility, since normally compatible is an exact
string match.

And i actually think this is the sort of change which should be as a
patch of its own. If this causes a regression, a git bisect would then
tell you if it is the change of usbether -> ethernet, or 0424 to
424. That is part of why we ask for lots of small changes.


       Andrew

On Tue, Feb 15, 2022 at 09:56:50PM +0100, Andrew Lunn wrote:
> > > > -	ethernet: usbether@2 {
> > > > -		compatible = "usb0424,9730";
> > > > +	ethernet: ethernet@2 {
> > > > +		compatible = "usb424,9730";
> > > 
> > > The change of the compatible is not mentioned in the patch description.
> > > Is this intentional?
> > 
> > No, I forgot to mentione it. According to the USB schema 0 should be
> > removed. So, this compatible was incorrect as well. With leading zero
> > present yaml schema was not able to detect and validate this node.
> 
> Does the current code not actually care about a leading 0? It will
> match with or without it? It would be good to mention that as well in
> the commit message, otherwise somebody like me is going to ask if this
> breaks backwards compatibility, since normally compatible is an exact
> string match.

Current kernel code do not care about exact this compatibles. There is
no driver matching against it. The USB Ethernet driver will take the
node provided by the USB core drivers without validating the compatible
against USB ID.
See:
drivers/usb/core/of.c
drivers/usb/core/message.c:2093

On other hand, DT validations tools do care about it and this nodes was
not detected automatically. I found it accidentally by grepping the
sources.

> And i actually think this is the sort of change which should be as a
> patch of its own. If this causes a regression, a git bisect would then
> tell you if it is the change of usbether -> ethernet, or 0424 to
> 424. That is part of why we ask for lots of small changes.

Sounds good, I'll update it.

Regards,
Oleksij