| Message ID | 20220224225635.40538-2-eajames@linux.ibm.com |
|---|---|
| State | Accepted |
| Commit | bc604fbb49f1a00df34e6755a32e8bf5419eb4cd |
| Headers | show |
| Series | [v4,1/2] dt-bindings: input: Add documentation for IBM Operation Panel | expand |
On Thu, 24 Feb 2022 16:56:34 -0600, Eddie James wrote: > Document the bindings for the IBM Operation Panel, which provides > a simple interface to control a server. It has a display and three > buttons. > Also update MAINTAINERS for the new file. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Joel Stanley <joel@jms.id.au> > --- > .../bindings/input/ibm,op-panel.yaml | 49 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ibm,op-panel.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/input/ibm,op-panel.example.dts:27.35-36 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/input/ibm,op-panel.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1398: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1597387 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/input/ibm,op-panel.yaml b/Documentation/devicetree/bindings/input/ibm,op-panel.yaml new file mode 100644 index 000000000000..08d8f194f0db --- /dev/null +++ b/Documentation/devicetree/bindings/input/ibm,op-panel.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/ibm,op-panel.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IBM Operation Panel + +maintainers: + - Eddie James <eajames@linux.ibm.com> + +allOf: + - $ref: input.yaml# + +description: | + The IBM Operation Panel provides a simple interface to control the connected + server. It has a display and three buttons: two directional arrows and one + 'Enter' button. + +properties: + compatible: + const: ibm,op-panel + + reg: + maxItems: 1 + + linux,keycodes: + minItems: 1 + maxItems: 3 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/i2c/i2c.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ibm-op-panel@62 { + compatible = "ibm,op-panel"; + reg = <(0x62 | I2C_OWN_SLAVE_ADDRESS)>; + linux,keycodes = <KEY_UP KEY_DOWN KEY_ENTER>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d2eef29691e7..f4c9db336223 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9233,6 +9233,12 @@ S: Orphan F: Documentation/ia64/ F: arch/ia64/ +IBM Operation Panel Input Driver +M: Eddie James <eajames@linux.ibm.com> +L: linux-input@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/input/ibm,op-panel.yaml + IBM Power 842 compression accelerator M: Haren Myneni <haren@us.ibm.com> S: Supported