diff mbox series

[v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC

Message ID 20220301125046.17737-1-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series [v2] dt-bindings: i2c: renesas,riic: Document RZ/V2L SoC | expand

Commit Message

Prabhakar Mahadev Lad March 1, 2022, 12:50 p.m. UTC 
Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
compatible string "renesas,riic-rz" will be used as a fallback.

While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
compatible string as this will avoid changing the line for every new
SoC addition.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v1->v2
* Included Ack and RB tags
* Dropped the comment from generic string as suggested by Geert.

v1:
https://patchwork.kernel.org/project/linux-renesas-soc/patch/
20220227214747.24819-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Wolfram Sang March 1, 2022, 4:32 p.m. UTC | #1 
On Tue, Mar 01, 2022 at 12:50:46PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
> RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
> compatible string "renesas,riic-rz" will be used as a fallback.
> 
> While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
> compatible string as this will avoid changing the line for every new
> SoC addition.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

If Rob wants to pick it up:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Rob Herring March 2, 2022, 6:24 p.m. UTC | #2 
On Tue, Mar 01, 2022 at 12:50:46PM +0000, Lad Prabhakar wrote:
> Document RZ/V2L I2C bindings. RZ/V2L I2C is identical to one found on the
> RZ/G2L and RZ/A SoC's. No driver changes are required as the generic
> compatible string "renesas,riic-rz" will be used as a fallback.
> 
> While at it, drop the comment "# RZ/A or RZ/G2L" for "renesas,riic-rz"
> compatible string as this will avoid changing the line for every new
> SoC addition.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1->v2
> * Included Ack and RB tags
> * Dropped the comment from generic string as suggested by Geert.
> 
> v1:
> https://patchwork.kernel.org/project/linux-renesas-soc/patch/
> 20220227214747.24819-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I already applied v1. I may have missed this because PW stopped getting 
mail the last 2 days.

Rob
Wolfram Sang March 2, 2022, 9:08 p.m. UTC | #3 
> I already applied v1. I may have missed this because PW stopped getting 
> mail the last 2 days.

Can you revert v1 and apply v2? Or I apply v2? Works both for me.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 402fd125e010..26d523f3f420 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -20,7 +20,8 @@  properties:
           - renesas,riic-r7s72100   # RZ/A1H
           - renesas,riic-r7s9210    # RZ/A2M
           - renesas,riic-r9a07g044  # RZ/G2{L,LC}
-      - const: renesas,riic-rz      # RZ/A or RZ/G2L
+          - renesas,riic-r9a07g054  # RZ/V2L
+      - const: renesas,riic-rz
 
   reg:
     maxItems: 1
@@ -75,6 +76,7 @@  if:
       contains:
         enum:
           - renesas,riic-r9a07g044
+          - renesas,riic-r9a07g054
 then:
   required:
     - resets