| Message ID | 20220307163840.64495-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | a9a5b720dc8227243f433141ba1343aa53ef57e4 |
| Headers | show |
| Series | [v1,1/1] gpio: sim: Declare gpio_sim_hog_config_item_ops static | expand |
On Mon, Mar 7, 2022 at 5:38 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Compiler is not happy: > > warning: symbol 'gpio_sim_hog_config_item_ops' was not declared. Should it be static? > > Fixes: cb8c474e79be ("gpio: sim: new testing module") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-sim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c > index 153fe79e1bf3..bb9bb595c1a8 100644 > --- a/drivers/gpio/gpio-sim.c > +++ b/drivers/gpio/gpio-sim.c > @@ -1322,7 +1322,7 @@ static void gpio_sim_hog_config_item_release(struct config_item *item) > kfree(hog); > } > > -struct configfs_item_operations gpio_sim_hog_config_item_ops = { > +static struct configfs_item_operations gpio_sim_hog_config_item_ops = { > .release = gpio_sim_hog_config_item_release, > }; > > -- > 2.34.1 > Queued for fixes, thanks! Bart
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index 153fe79e1bf3..bb9bb595c1a8 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -1322,7 +1322,7 @@ static void gpio_sim_hog_config_item_release(struct config_item *item) kfree(hog); } -struct configfs_item_operations gpio_sim_hog_config_item_ops = { +static struct configfs_item_operations gpio_sim_hog_config_item_ops = { .release = gpio_sim_hog_config_item_release, };
Compiler is not happy: warning: symbol 'gpio_sim_hog_config_item_ops' was not declared. Should it be static? Fixes: cb8c474e79be ("gpio: sim: new testing module") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)