diff mbox series

USB: serial: usb_wwan: remove redundant assignment to variable i

Message ID 20220307183100.150082-1-colin.i.king@gmail.com
State New
Headers show
Series USB: serial: usb_wwan: remove redundant assignment to variable i | expand

Commit Message

Colin Ian King March 7, 2022, 6:31 p.m. UTC
Variable i is being assigned a value that is never read, it is being
re-assigned two statements later in a for-loop. The assignment is
redundant and can be removed.

Cleans up clang scan build warning:
drivers/usb/serial/usb_wwan.c:151:2: warning: Value stored to 'i'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/usb/serial/usb_wwan.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Johan Hovold March 8, 2022, 5:53 p.m. UTC | #1
On Mon, Mar 07, 2022 at 06:31:00PM +0000, Colin Ian King wrote:
> Variable i is being assigned a value that is never read, it is being
> re-assigned two statements later in a for-loop. The assignment is
> redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/usb/serial/usb_wwan.c:151:2: warning: Value stored to 'i'
> is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied, thanks.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
index cb01283d4d15..dab38b63eaf7 100644
--- a/drivers/usb/serial/usb_wwan.c
+++ b/drivers/usb/serial/usb_wwan.c
@@ -148,7 +148,6 @@  int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
 
 	dev_dbg(&port->dev, "%s: write (%d chars)\n", __func__, count);
 
-	i = 0;
 	left = count;
 	for (i = 0; left > 0 && i < N_OUT_URB; i++) {
 		todo = left;