| Message ID | 20220311164628.378849-2-gengcixi@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: sc27xx: adjust structure and add PMIC's support | expand |
On Sat, 12 Mar 2022 00:46:22 +0800 Cixi Geng <gengcixi@gmail.com> wrote: > From: Cixi Geng <cixi.geng1@unisoc.com> In title, use dt-binding instead of dtbindings at the end. > > sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in > dtbindings. dt-bindings. > > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> If the patch was authored by Chunyan Zhang, it should be From: Chunyan Zhang, if it is more complex than you simply passing the patch on then we should see a co-developed to indicate that. Patch looks good to me Jonathan > --- > .../bindings/iio/adc/sprd,sc2720-adc.yaml | 30 +++++++++++++++++-- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > index caa3ee0b4b8c..331b08fb1761 100644 > --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > @@ -20,6 +20,7 @@ properties: > - sprd,sc2723-adc > - sprd,sc2730-adc > - sprd,sc2731-adc > + - sprd,ump9620-adc > > reg: > maxItems: 1 > @@ -37,9 +38,32 @@ properties: > maxItems: 2 > > nvmem-cell-names: > - items: > - - const: big_scale_calib > - - const: small_scale_calib > + description: Names for each nvmem-cells specified. > + > +if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - sprd,ump9620-adc > +then: > + properties: > + nvmem-cell-names: > + items: > + - const: big_scale_calib > + - const: small_scale_calib > + > +else: > + properties: > + nvmem-cell-names: > + items: > + - const: big_scale_calib1 > + - const: big_scale_calib2 > + - const: small_scale_calib1 > + - const: small_scale_calib2 > + - const: vbat_det_cal1 > + - const: vbat_det_cal2 > > required: > - compatible
On 11/03/2022 17:46, Cixi Geng wrote: > From: Cixi Geng <cixi.geng1@unisoc.com> > > sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in > dtbindings. > > Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > --- > .../bindings/iio/adc/sprd,sc2720-adc.yaml | 30 +++++++++++++++++-- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > index caa3ee0b4b8c..331b08fb1761 100644 > --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml > @@ -20,6 +20,7 @@ properties: > - sprd,sc2723-adc > - sprd,sc2730-adc > - sprd,sc2731-adc > + - sprd,ump9620-adc > > reg: > maxItems: 1 > @@ -37,9 +38,32 @@ properties: > maxItems: 2 > > nvmem-cell-names: > - items: > - - const: big_scale_calib > - - const: small_scale_calib Please test your changes with dt_binding_check and dtbs_check. Your change looks not complete - you have still nvmem-cells = 2. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml index caa3ee0b4b8c..331b08fb1761 100644 --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml @@ -20,6 +20,7 @@ properties: - sprd,sc2723-adc - sprd,sc2730-adc - sprd,sc2731-adc + - sprd,ump9620-adc reg: maxItems: 1 @@ -37,9 +38,32 @@ properties: maxItems: 2 nvmem-cell-names: - items: - - const: big_scale_calib - - const: small_scale_calib + description: Names for each nvmem-cells specified. + +if: + not: + properties: + compatible: + contains: + enum: + - sprd,ump9620-adc +then: + properties: + nvmem-cell-names: + items: + - const: big_scale_calib + - const: small_scale_calib + +else: + properties: + nvmem-cell-names: + items: + - const: big_scale_calib1 + - const: big_scale_calib2 + - const: small_scale_calib1 + - const: small_scale_calib2 + - const: vbat_det_cal1 + - const: vbat_det_cal2 required: - compatible