From patchwork Fri Oct 16 12:32:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 55098 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by patches.linaro.org (Postfix) with ESMTPS id 8955322FFA for ; Fri, 16 Oct 2015 12:32:58 +0000 (UTC) Received: by lbbor1 with SMTP id or1sf5344639lbb.2 for ; Fri, 16 Oct 2015 05:32:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=3ThiMCgeoSBT+PiKZX/8auHd13XA14gT5ZbnNU1y9/o=; b=ZLqXjOfTKGXzLnm0wz97yGlMunRkpewiQzBFfjh/F0axSPZUHzf+di+E/u7zmAhT6d 6M7CkqJn7m09M1tRsbWOEmeR9+Foha8VtRDA6ljydD8q8TLZ6Mhh8JLUPvcCIAESGZeC 7tZxLSInU5YM7kvD7CiQFey7XRC0tORnEw8JSuYjPYSpLn8xvtnn2qw1NoH5OZq6c6va esEGV8PxXycpFRylfZSL9S097mO0GH0jicJd5LYJ8DkEMPtxHUF2tcxGi4DCTU8BQw1g I3uolRAG4Bwd2KDhYnhKX5UqJ3PHAiArSP8jF9dkn4h9PtKKmsnMiZxLVFF1pYsYILc1 eBsA== X-Gm-Message-State: ALoCoQlj8cai7nd/QBF+zexTuoyvl1kxOcF9Y5K6Esas3e29j132DPTazECwVuHmZccT89K6qI0U X-Received: by 10.194.71.107 with SMTP id t11mr239129wju.6.1444998777126; Fri, 16 Oct 2015 05:32:57 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.206.211 with SMTP id e202ls321058lfg.109.gmail; Fri, 16 Oct 2015 05:32:56 -0700 (PDT) X-Received: by 10.25.161.136 with SMTP id k130mr5422398lfe.25.1444998776933; Fri, 16 Oct 2015 05:32:56 -0700 (PDT) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id 63si11660832lfv.69.2015.10.16.05.32.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Oct 2015 05:32:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by lfaz124 with SMTP id z124so78850241lfa.1 for ; Fri, 16 Oct 2015 05:32:56 -0700 (PDT) X-Received: by 10.25.28.81 with SMTP id c78mr5342214lfc.29.1444998776566; Fri, 16 Oct 2015 05:32:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1254080lbq; Fri, 16 Oct 2015 05:32:55 -0700 (PDT) X-Received: by 10.68.65.67 with SMTP id v3mr10441359pbs.69.1444998775304; Fri, 16 Oct 2015 05:32:55 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id wv1si29354856pab.150.2015.10.16.05.32.54; Fri, 16 Oct 2015 05:32:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbbJPMcx (ORCPT + 30 others); Fri, 16 Oct 2015 08:32:53 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35138 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631AbbJPMcw (ORCPT ); Fri, 16 Oct 2015 08:32:52 -0400 Received: by wicll6 with SMTP id ll6so7793277wic.0 for ; Fri, 16 Oct 2015 05:32:51 -0700 (PDT) X-Received: by 10.194.204.195 with SMTP id la3mr16352903wjc.77.1444998770915; Fri, 16 Oct 2015 05:32:50 -0700 (PDT) Received: from x1 (host81-129-170-218.range81-129.btcentralplus.com. [81.129.170.218]) by smtp.gmail.com with ESMTPSA id h7sm22309576wjz.7.2015.10.16.05.32.49 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 16 Oct 2015 05:32:50 -0700 (PDT) Date: Fri, 16 Oct 2015 13:32:47 +0100 From: Lee Jones To: jassisinghbrar@gmail.com Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, devicetree@vger.kernel.org, kbuild test robot Subject: [PATCH v2] mailbox: Fix a couple of trivial static checker issues Message-ID: <20151016123247.GG31804@x1> References: <1444980091-16728-5-git-send-email-lee.jones@linaro.org> <201510161646.D4m1dK6L%fengguang.wu@intel.com> <20151016113251.GF31804@x1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151016113251.GF31804@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , mailbox: Fix a couple of trivial static checker issues This patch deals with a few spelling, white space and type warnings reported by Intel's Kbuild Test Robot. Reported-by: kbuild test robot Signed-off-by: Lee Jones --- v1 => v2: Looks like I took the AKA in this too literally: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' After some research I found a new printk format specifier suitable for size_t. drivers/mailbox/mailbox-sti.c | 2 +- drivers/mailbox/mailbox-test.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c index f11d4e8..4835817 100644 --- a/drivers/mailbox/mailbox-sti.c +++ b/drivers/mailbox/mailbox-sti.c @@ -64,7 +64,7 @@ struct sti_mbox_device { }; /** - * STi Mailbox platform specfic configuration + * STi Mailbox platform specific configuration * * @num_inst: Maximum number of instances in one HW Mailbox * @num_chan: Maximum number of channel per instance diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index cac1ba2..22f2e40 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -22,7 +22,7 @@ #define MBOX_MAX_SIG_LEN 8 #define MBOX_MAX_MSG_LEN 128 #define MBOX_BYTES_PER_LINE 16 -#define MBOX_HEXDUMP_LINE_LEN ((MBOX_BYTES_PER_LINE * 4) + 2) +#define MBOX_HEXDUMP_LINE_LEN ((MBOX_BYTES_PER_LINE * 4) + 2) #define MBOX_HEXDUMP_MAX_LEN (MBOX_HEXDUMP_LINE_LEN * \ (MBOX_MAX_MSG_LEN / MBOX_BYTES_PER_LINE)) @@ -30,7 +30,7 @@ static struct dentry *root_debugfs_dir; struct mbox_test_device { struct device *dev; - void __iomem *mmio; + void *mmio; struct mbox_chan *tx_channel; struct mbox_chan *rx_channel; char *rx_buffer; @@ -53,7 +53,7 @@ static ssize_t mbox_test_signal_write(struct file *filp, if (count > MBOX_MAX_SIG_LEN) { dev_err(tdev->dev, - "Signal length %d greater than max allowed %d\n", + "Signal length %zd greater than max allowed %d\n", count, MBOX_MAX_SIG_LEN); return -EINVAL; } @@ -92,7 +92,7 @@ static ssize_t mbox_test_message_write(struct file *filp, if (count > MBOX_MAX_MSG_LEN) { dev_err(tdev->dev, - "Message length %d greater than max allowed %d\n", + "Message length %zd greater than max allowed %d\n", count, MBOX_MAX_MSG_LEN); return -EINVAL; } @@ -303,7 +303,7 @@ static int mbox_test_probe(struct platform_device *pdev) tdev->tx_channel = mbox_test_request_channel(pdev, "tx"); tdev->rx_channel = mbox_test_request_channel(pdev, "rx"); - if (!tdev->tx_channel && !tdev->tx_channel) + if (!tdev->tx_channel && !tdev->rx_channel) return -EPROBE_DEFER; tdev->dev = &pdev->dev;