| Message ID | 20220314184113.251013-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: exynos: drop deprecated SFR region from MIPI phy | expand |
Hi Krzysztof, >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Tuesday, March 15, 2022 12:11 AM >To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski ><krzk+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>; >devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org >Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sylwester Nawrocki ><snawrocki@kernel.org>; Krzysztof Kozlowski ><krzysztof.kozlowski@canonical.com> >Subject: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI >phy > >Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding >support for PMU regmap") deprecated the usage of unit address in MIPI phy >node, in favor of a syscon phandle. Deprecating was a correct approach >because that unit address was actually coming from Power Management Unit >SFR range so its usage here caused overlapped memory mapping. > >In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for >direct access to PMU") fully removed support for parsing that MIPI phy unit >address (SFR range) but the address stayed in Exynos5250 DTSI for >compatibility reasons. > >Remove that deprecated unit address from Exynos5250 MIPI phy, because it >has been almost 6 years since it was deprecated and it causes now DT schema >validation warnings: > > video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0- >9]+' > >Any out-of-tree users of Exynos5250 DTSI, should update their code to use >newer syscon property. > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >--- Reviewed-by: Alim Akhtar<alim.akhtar@samsung.com> > arch/arm/boot/dts/exynos5250.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/arch/arm/boot/dts/exynos5250.dtsi >b/arch/arm/boot/dts/exynos5250.dtsi >index 5baaa7eb71a4..d8d401b5ca48 100644 >--- a/arch/arm/boot/dts/exynos5250.dtsi >+++ b/arch/arm/boot/dts/exynos5250.dtsi >@@ -817,15 +817,14 @@ mixer: mixer@14450000 { > status = "disabled"; > }; > >- dp_phy: video-phy { >+ dp_phy: video-phy-0 { > compatible = "samsung,exynos5250-dp-video-phy"; > samsung,pmu-syscon = <&pmu_system_controller>; > #phy-cells = <0>; > }; > >- mipi_phy: video-phy@10040710 { >+ mipi_phy: video-phy-1 { > compatible = "samsung,s5pv210-mipi-video-phy"; >- reg = <0x10040710 0x100>; > #phy-cells = <1>; > syscon = <&pmu_system_controller>; > }; >-- >2.32.0
On Mon, 14 Mar 2022 19:41:13 +0100, Krzysztof Kozlowski wrote: > Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding > support for PMU regmap") deprecated the usage of unit address in MIPI > phy node, in favor of a syscon phandle. Deprecating was a correct > approach because that unit address was actually coming from Power > Management Unit SFR range so its usage here caused overlapped memory > mapping. > > [...] Applied, thanks! [1/1] ARM: dts: exynos: drop deprecated SFR region from MIPI phy commit: 04398e04173f1be0b21d7cd50c54e8affcebe106 Best regards,
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 5baaa7eb71a4..d8d401b5ca48 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -817,15 +817,14 @@ mixer: mixer@14450000 { status = "disabled"; }; - dp_phy: video-phy { + dp_phy: video-phy-0 { compatible = "samsung,exynos5250-dp-video-phy"; samsung,pmu-syscon = <&pmu_system_controller>; #phy-cells = <0>; }; - mipi_phy: video-phy@10040710 { + mipi_phy: video-phy-1 { compatible = "samsung,s5pv210-mipi-video-phy"; - reg = <0x10040710 0x100>; #phy-cells = <1>; syscon = <&pmu_system_controller>; };
Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") deprecated the usage of unit address in MIPI phy node, in favor of a syscon phandle. Deprecating was a correct approach because that unit address was actually coming from Power Management Unit SFR range so its usage here caused overlapped memory mapping. In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for direct access to PMU") fully removed support for parsing that MIPI phy unit address (SFR range) but the address stayed in Exynos5250 DTSI for compatibility reasons. Remove that deprecated unit address from Exynos5250 MIPI phy, because it has been almost 6 years since it was deprecated and it causes now DT schema validation warnings: video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' Any out-of-tree users of Exynos5250 DTSI, should update their code to use newer syscon property. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm/boot/dts/exynos5250.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)