| Message ID | 20220315204306.2797684-3-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm: Improve M-profile exception logging | expand |
On 3/15/22 13:43, Peter Maydell wrote: > For M-profile, the fault address is not always exposed to the guest > in a fault register (for instance the BFAR bus fault address register > is only updated for bus faults on data accesses, not instruction > accesses). Currently we log the address only if we're putting it > into a particular guest-visible register. Since we always have it, > log it generically, to make logs of i-side faults a bit clearer. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > target/arm/m_helper.c | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Peter Maydell <peter.maydell@linaro.org> writes: > For M-profile, the fault address is not always exposed to the guest > in a fault register (for instance the BFAR bus fault address register > is only updated for bus faults on data accesses, not instruction > accesses). Currently we log the address only if we're putting it > into a particular guest-visible register. Since we always have it, > log it generically, to make logs of i-side faults a bit clearer. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c index 3bd16c0c465..b7a0fe01141 100644 --- a/target/arm/m_helper.c +++ b/target/arm/m_helper.c @@ -2272,7 +2272,13 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs) * Note that for M profile we don't have a guest facing FSR, but * the env->exception.fsr will be populated by the code that * raises the fault, in the A profile short-descriptor format. + * + * Log the exception.vaddress now regardless of subtype, because + * logging below only logs it when it goes into a guest visible + * register. */ + qemu_log_mask(CPU_LOG_INT, "...at fault address 0x%x\n", + (uint32_t)env->exception.vaddress); switch (env->exception.fsr & 0xf) { case M_FAKE_FSR_NSC_EXEC: /*
For M-profile, the fault address is not always exposed to the guest in a fault register (for instance the BFAR bus fault address register is only updated for bus faults on data accesses, not instruction accesses). Currently we log the address only if we're putting it into a particular guest-visible register. Since we always have it, log it generically, to make logs of i-side faults a bit clearer. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/m_helper.c | 6 ++++++ 1 file changed, 6 insertions(+)