| Message ID | 20220315102245.15031-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 7208fdce270bb3e635a9b2fd9e444b7f3c1817fc |
| Headers | show |
| Series | media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation | expand |
Hi Laurent, Quoting Laurent Pinchart (2022-03-15 10:22:45) > The v4l2_m2m_dev structure documentation incorrectly references the > v4l2_m2m_unregister_media_controller() function when it actually means > v4l2_m2m_register_media_controller(). Fix it. > Eeep, that's a bit of an ooops. Patch looks good. I guess Doc-only means no fixes tag required? Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c > index e2654b422334..ed1280adf7ff 100644 > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c > @@ -68,16 +68,16 @@ static const char * const m2m_entity_name[] = { > * struct v4l2_m2m_dev - per-device context > * @source: &struct media_entity pointer with the source entity > * Used only when the M2M device is registered via > - * v4l2_m2m_unregister_media_controller(). > + * v4l2_m2m_register_media_controller(). > * @source_pad: &struct media_pad with the source pad. > * Used only when the M2M device is registered via > - * v4l2_m2m_unregister_media_controller(). > + * v4l2_m2m_register_media_controller(). > * @sink: &struct media_entity pointer with the sink entity > * Used only when the M2M device is registered via > - * v4l2_m2m_unregister_media_controller(). > + * v4l2_m2m_register_media_controller(). > * @sink_pad: &struct media_pad with the sink pad. > * Used only when the M2M device is registered via > - * v4l2_m2m_unregister_media_controller(). > + * v4l2_m2m_register_media_controller(). > * @proc: &struct media_entity pointer with the M2M device itself. > * @proc_pads: &struct media_pad with the @proc pads. > * Used only when the M2M device is registered via > -- > Regards, > > Laurent Pinchart >
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index e2654b422334..ed1280adf7ff 100644 --- a/drivers/media/v4l2-core/v4l2-mem2mem.c +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c @@ -68,16 +68,16 @@ static const char * const m2m_entity_name[] = { * struct v4l2_m2m_dev - per-device context * @source: &struct media_entity pointer with the source entity * Used only when the M2M device is registered via - * v4l2_m2m_unregister_media_controller(). + * v4l2_m2m_register_media_controller(). * @source_pad: &struct media_pad with the source pad. * Used only when the M2M device is registered via - * v4l2_m2m_unregister_media_controller(). + * v4l2_m2m_register_media_controller(). * @sink: &struct media_entity pointer with the sink entity * Used only when the M2M device is registered via - * v4l2_m2m_unregister_media_controller(). + * v4l2_m2m_register_media_controller(). * @sink_pad: &struct media_pad with the sink pad. * Used only when the M2M device is registered via - * v4l2_m2m_unregister_media_controller(). + * v4l2_m2m_register_media_controller(). * @proc: &struct media_entity pointer with the M2M device itself. * @proc_pads: &struct media_pad with the @proc pads. * Used only when the M2M device is registered via
The v4l2_m2m_dev structure documentation incorrectly references the v4l2_m2m_unregister_media_controller() function when it actually means v4l2_m2m_register_media_controller(). Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)