diff mbox series

[01/15] arm64: dts: qcom: msm8994: Fix sleep clock name

Message ID 20220319174645.340379-2-konrad.dybcio@somainline.org
State Accepted
Commit 5827e28304673444f8e1cf426c2b08cc16382290
Headers show
Series [01/15] arm64: dts: qcom: msm8994: Fix sleep clock name | expand

Commit Message

Konrad Dybcio March 19, 2022, 5:46 p.m. UTC
The sleep clock name expected by GCC is actually "sleep" and not
"sleep_clk". Fix the clock-names value for it to make sure it is
provided.

Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel March 23, 2022, 9:06 p.m. UTC | #1
Hi Konrad, all,

> The sleep clock name expected by GCC is actually "sleep" and not
> "sleep_clk". Fix the clock-names value for it to make sure it is
> provided.

> Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")
Thanks for fixing it, now I see it in
Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

I also tested it with "clk: qcom: gcc-msm8994: Fix gpll4 width" [1]
and "[PATCH v5 1/1] arm64: dts: qcom: msm8994-huawei-angler: Add sdhc1 definition" [2]
and it works as expected.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

[1] https://lore.kernel.org/linux-arm-msm/20220319174940.341137-1-konrad.dybcio@somainline.org/
[2] https://lore.kernel.org/linux-arm-msm/20220323204840.22832-1-petr.vorel@gmail.com/
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index 215f56daa26c..c7bb8235a169 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -714,7 +714,7 @@  gcc: clock-controller@fc400000 {
 			#power-domain-cells = <1>;
 			reg = <0xfc400000 0x2000>;
 
-			clock-names = "xo", "sleep_clk";
+			clock-names = "xo", "sleep";
 			clocks = <&xo_board>, <&sleep_clk>;
 		};