| Message ID | 1647532165-6302-3-git-send-email-quic_c_sbhanu@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add reset entries for SDCC controllers | expand |
Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25) > Add gcc hardware reset entries for eMMC and SD card. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index c07765d..cd50ea3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -881,6 +881,10 @@ > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > > + /* gcc hardware reset entry for eMMC */ Please don't add this worthless comment. > + resets = <&gcc GCC_SDCC1_BCR>; > + reset-names = "core_reset"; A "_reset" postfix is redundant. In fact, reset-names shouldn't even be required. > + > sdhc1_opp_table: opp-table { > compatible = "operating-points-v2"; > > @@ -2686,6 +2690,10 @@ > > qcom,dll-config = <0x0007642c>; > > + /* gcc hardware reset entry for SD card */ Please don't add this worthless comment. > + resets = <&gcc GCC_SDCC2_BCR>; > + reset-names = "core_reset"; > + > sdhc2_opp_table: opp-table { > compatible = "operating-points-v2"; >
Hi, Thanks for the review. Please find the inline comments. Thanks, Sajida On 4/2/2022 3:39 AM, Stephen Boyd wrote: > Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25) >> Add gcc hardware reset entries for eMMC and SD card. >> >> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index c07765d..cd50ea3 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -881,6 +881,10 @@ >> mmc-hs400-1_8v; >> mmc-hs400-enhanced-strobe; >> >> + /* gcc hardware reset entry for eMMC */ > Please don't add this worthless comment. > >> + resets = <&gcc GCC_SDCC1_BCR>; >> + reset-names = "core_reset"; > A "_reset" postfix is redundant. In fact, reset-names shouldn't even be > required. Ok >> + >> sdhc1_opp_table: opp-table { >> compatible = "operating-points-v2"; >> >> @@ -2686,6 +2690,10 @@ >> >> qcom,dll-config = <0x0007642c>; >> >> + /* gcc hardware reset entry for SD card */ > Please don't add this worthless comment. Sure will remove the comment. >> + resets = <&gcc GCC_SDCC2_BCR>; >> + reset-names = "core_reset"; >> + >> sdhc2_opp_table: opp-table { >> compatible = "operating-points-v2"; >>
+ Bhupesh Sharma On Thu, 17 Mar 2022 at 16:49, Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> wrote: > > Add gcc hardware reset entries for eMMC and SD card. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> As I just replied to Bhupesh Sharma, it would be nice to get all the mmc DT bindings converted to the yaml format. Would you mind having a look at doing the conversion first, thus prior to extending the existing text-based docs? Kind regards Uffe > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index c07765d..cd50ea3 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -881,6 +881,10 @@ > mmc-hs400-1_8v; > mmc-hs400-enhanced-strobe; > > + /* gcc hardware reset entry for eMMC */ > + resets = <&gcc GCC_SDCC1_BCR>; > + reset-names = "core_reset"; > + > sdhc1_opp_table: opp-table { > compatible = "operating-points-v2"; > > @@ -2686,6 +2690,10 @@ > > qcom,dll-config = <0x0007642c>; > > + /* gcc hardware reset entry for SD card */ > + resets = <&gcc GCC_SDCC2_BCR>; > + reset-names = "core_reset"; > + > sdhc2_opp_table: opp-table { > compatible = "operating-points-v2"; > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index c07765d..cd50ea3 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -881,6 +881,10 @@ mmc-hs400-1_8v; mmc-hs400-enhanced-strobe; + /* gcc hardware reset entry for eMMC */ + resets = <&gcc GCC_SDCC1_BCR>; + reset-names = "core_reset"; + sdhc1_opp_table: opp-table { compatible = "operating-points-v2"; @@ -2686,6 +2690,10 @@ qcom,dll-config = <0x0007642c>; + /* gcc hardware reset entry for SD card */ + resets = <&gcc GCC_SDCC2_BCR>; + reset-names = "core_reset"; + sdhc2_opp_table: opp-table { compatible = "operating-points-v2";
Add gcc hardware reset entries for eMMC and SD card. Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)