diff mbox series

mtd: rawnand: print offset instead of page number for bad blocks

Message ID 20220326163304.30806-1-zajec5@gmail.com
State New
Headers show
Series mtd: rawnand: print offset instead of page number for bad blocks | expand

Commit Message

Rafał Miłecki March 26, 2022, 4:33 p.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

This makes printed info consistent with other kernel messages. After
scanning NAND BBT create_bbt() prints offset of each bad block. This
change makes is easy to verify nand_erase_nand() failure reason.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
I noticed this inconsistency while using "flash_erase" tool.
---
 drivers/mtd/nand/raw/nand_base.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Miquel Raynal April 4, 2022, 8:47 a.m. UTC | #1 
On Sat, 2022-03-26 at 16:33:04 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This makes printed info consistent with other kernel messages. After
> scanning NAND BBT create_bbt() prints offset of each bad block. This
> change makes is easy to verify nand_erase_nand() failure reason.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 284fff62ac49..6b67b7dfe7ce 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -4502,11 +4502,13 @@  int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
 	len = instr->len;
 
 	while (len) {
+		loff_t ofs = (loff_t)page << chip->page_shift;
+
 		/* Check if we have a bad block, we do not erase bad blocks! */
 		if (nand_block_checkbad(chip, ((loff_t) page) <<
 					chip->page_shift, allowbbt)) {
-			pr_warn("%s: attempt to erase a bad block at page 0x%08x\n",
-				    __func__, page);
+			pr_warn("%s: attempt to erase a bad block at 0x%08llx\n",
+				    __func__, (unsigned long long)ofs);
 			ret = -EIO;
 			goto erase_exit;
 		}
@@ -4524,8 +4526,7 @@  int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
 		if (ret) {
 			pr_debug("%s: failed erase, page 0x%08x\n",
 					__func__, page);
-			instr->fail_addr =
-				((loff_t)page << chip->page_shift);
+			instr->fail_addr = ofs;
 			goto erase_exit;
 		}