| Message ID | 20220323141737.211198-1-zhongbaisong@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] ASoC: tlv320adc3xxx: Fix build error when GPIOLIB is not set | expand |
On Wed, Mar 23, 2022 at 10:17:36PM +0800, Baisong Zhong wrote: > config SND_SOC_TLV320ADC3XXX > tristate "Texas Instruments TLV320ADC3001/3101 audio ADC" > - depends on I2C > + depends on I2C && GPIOLIB This is bogus, the device clearly doesn't require GPIOs to be useful and so there shouldn't be a dependency on gpiolib which normally stubs out. In general for APIs with stubs adding a config dependency is not the right thing to do. I suspect it's just a missing header.
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index f46a22660103..1400fc75fd65 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1535,7 +1535,7 @@ config SND_SOC_TFA989X config SND_SOC_TLV320ADC3XXX tristate "Texas Instruments TLV320ADC3001/3101 audio ADC" - depends on I2C + depends on I2C && GPIOLIB help Enable support for Texas Instruments TLV320ADC3001 and TLV320ADC3101 ADCs.
sound/soc/codecs/tlv320adc3xxx.c:1352:21: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? sound/soc/codecs/tlv320adc3xxx.c:1352:50: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’? sound/soc/codecs/tlv320adc3xxx.c:1400:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)