diff mbox series

media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV

Message ID 20220331123151.1953-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 62c31868f528e8657947694913f1e76db816425b
Headers show
Series media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV | expand

Commit Message

Laurent Pinchart March 31, 2022, 12:31 p.m. UTC
The imx-mipi-csis driver (VIDEO_IMX_MIPI_CSIS) lost its dependency on
VIDEO_DEV in commit 63fe3d27b226 ("media: platform/*/Kconfig: make
manufacturer menus more uniform"). This causes build failures with
configurations that don't have VIDEO_DEV set. Fix it by restoring the
dependency.

Fixes: 63fe3d27b226 ("media: platform/*/Kconfig: make manufacturer menus more uniform")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Mauro, this fixes a regression in Linus' master branch, and is thus a
candidate fix for v5.18.
---
 drivers/media/platform/nxp/Kconfig | 1 +
 1 file changed, 1 insertion(+)


base-commit: 787af64d05cd528aac9ad16752d11bb1c6061bb9

Comments

Ezequiel Garcia April 2, 2022, 11:43 a.m. UTC | #1
Hi Laurent,

On Thu, Mar 31, 2022 at 03:31:51PM +0300, Laurent Pinchart wrote:
> The imx-mipi-csis driver (VIDEO_IMX_MIPI_CSIS) lost its dependency on
> VIDEO_DEV in commit 63fe3d27b226 ("media: platform/*/Kconfig: make
> manufacturer menus more uniform"). This causes build failures with
> configurations that don't have VIDEO_DEV set. Fix it by restoring the
> dependency.
> 
> Fixes: 63fe3d27b226 ("media: platform/*/Kconfig: make manufacturer menus more uniform")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Thanks,
Ezequiel

> ---
> Mauro, this fixes a regression in Linus' master branch, and is thus a
> candidate fix for v5.18.
> ---
>  drivers/media/platform/nxp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
> index 28f2bafc14d2..5afa373e534f 100644
> --- a/drivers/media/platform/nxp/Kconfig
> +++ b/drivers/media/platform/nxp/Kconfig
> @@ -7,6 +7,7 @@ comment "NXP media platform drivers"
>  config VIDEO_IMX_MIPI_CSIS
>  	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
>  	depends on ARCH_MXC || COMPILE_TEST
> +	depends on VIDEO_DEV
>  	select MEDIA_CONTROLLER
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
> 
> base-commit: 787af64d05cd528aac9ad16752d11bb1c6061bb9
> -- 
> Regards,
> 
> Laurent Pinchart
>
diff mbox series

Patch

diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig
index 28f2bafc14d2..5afa373e534f 100644
--- a/drivers/media/platform/nxp/Kconfig
+++ b/drivers/media/platform/nxp/Kconfig
@@ -7,6 +7,7 @@  comment "NXP media platform drivers"
 config VIDEO_IMX_MIPI_CSIS
 	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
 	depends on ARCH_MXC || COMPILE_TEST
+	depends on VIDEO_DEV
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API