| Message ID | 20220331223424.1054715-16-bvanassche@acm.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | UFS patches for kernel v5.19 | expand |
> Driver version numbers are not useful in upstream kernel code. Hence Yet still - very common across the stack, and particularly in many scsi low level drivers. Why the ufs drivers is any different? > remove the driver version number from the UFS driver. > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/ufs/cdns-pltfrm.c | 1 - > drivers/scsi/ufs/ufshcd-pci.c | 1 - > drivers/scsi/ufs/ufshcd-pltfrm.c | 1 - > drivers/scsi/ufs/ufshcd.c | 1 - > drivers/scsi/ufs/ufshcd.h | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c > index 7da8be2f35c4..e91cf9fd5a95 100644 > --- a/drivers/scsi/ufs/cdns-pltfrm.c > +++ b/drivers/scsi/ufs/cdns-pltfrm.c > @@ -340,4 +340,3 @@ module_platform_driver(cdns_ufs_pltfrm_driver); > MODULE_AUTHOR("Jan Kotas <jank@cadence.com>"); > MODULE_DESCRIPTION("Cadence UFS host controller platform driver"); > MODULE_LICENSE("GPL v2"); > -MODULE_VERSION(UFSHCD_DRIVER_VERSION); > diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c > index f76692053ca1..81aa14661072 100644 > --- a/drivers/scsi/ufs/ufshcd-pci.c > +++ b/drivers/scsi/ufs/ufshcd-pci.c > @@ -601,4 +601,3 @@ MODULE_AUTHOR("Santosh Yaragnavi > <santosh.sy@samsung.com>"); > MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); > MODULE_DESCRIPTION("UFS host controller PCI glue driver"); > MODULE_LICENSE("GPL"); > -MODULE_VERSION(UFSHCD_DRIVER_VERSION); > diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c > index 2725ce4de1c9..81e458d31222 100644 > --- a/drivers/scsi/ufs/ufshcd-pltfrm.c > +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c > @@ -386,4 +386,3 @@ MODULE_AUTHOR("Santosh Yaragnavi > <santosh.sy@samsung.com>"); > MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); > MODULE_DESCRIPTION("UFS host controller Platform bus based glue driver"); > MODULE_LICENSE("GPL"); > -MODULE_VERSION(UFSHCD_DRIVER_VERSION); > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index ae08c7964f2d..9d433d2c616d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -9915,4 +9915,3 @@ MODULE_AUTHOR("Santosh Yaragnavi > <santosh.sy@samsung.com>"); > MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); > MODULE_DESCRIPTION("Generic UFS host controller driver Core"); > MODULE_LICENSE("GPL"); > -MODULE_VERSION(UFSHCD_DRIVER_VERSION); > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index bb2624aabda2..49edbdb5ffd6 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -49,7 +49,6 @@ > #include "ufshci.h" > > #define UFSHCD "ufshcd" > -#define UFSHCD_DRIVER_VERSION "0.2" > > struct ufs_hba;
On Thu, 2022-03-31 at 15:34 -0700, Bart Van Assche wrote: > Driver version numbers are not useful in upstream kernel code. Hence > remove the driver version number from the UFS driver. > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Bean Huo <beanhuo@micron.com>
On 4/3/22 00:10, Avri Altman wrote: >> Driver version numbers are not useful in upstream kernel code. Hence > Yet still - very common across the stack, and particularly in many scsi low level drivers. > Why the ufs drivers is any different? Some authors of SCSI drivers use the version number to track which version of their driver ends up in Linux distributions like RHEL or SLES. I think that the driver version numbers are not useful in the UFS drivers because the current version number is 0.2 and that version number was assigned in 2013, more than nine years ago. See also commit e0eca63e3421 ("[SCSI] ufs: Separate PCI code into glue driver"). Thanks, Bart.
diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c index 7da8be2f35c4..e91cf9fd5a95 100644 --- a/drivers/scsi/ufs/cdns-pltfrm.c +++ b/drivers/scsi/ufs/cdns-pltfrm.c @@ -340,4 +340,3 @@ module_platform_driver(cdns_ufs_pltfrm_driver); MODULE_AUTHOR("Jan Kotas <jank@cadence.com>"); MODULE_DESCRIPTION("Cadence UFS host controller platform driver"); MODULE_LICENSE("GPL v2"); -MODULE_VERSION(UFSHCD_DRIVER_VERSION); diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c index f76692053ca1..81aa14661072 100644 --- a/drivers/scsi/ufs/ufshcd-pci.c +++ b/drivers/scsi/ufs/ufshcd-pci.c @@ -601,4 +601,3 @@ MODULE_AUTHOR("Santosh Yaragnavi <santosh.sy@samsung.com>"); MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); MODULE_DESCRIPTION("UFS host controller PCI glue driver"); MODULE_LICENSE("GPL"); -MODULE_VERSION(UFSHCD_DRIVER_VERSION); diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 2725ce4de1c9..81e458d31222 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -386,4 +386,3 @@ MODULE_AUTHOR("Santosh Yaragnavi <santosh.sy@samsung.com>"); MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); MODULE_DESCRIPTION("UFS host controller Platform bus based glue driver"); MODULE_LICENSE("GPL"); -MODULE_VERSION(UFSHCD_DRIVER_VERSION); diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index ae08c7964f2d..9d433d2c616d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -9915,4 +9915,3 @@ MODULE_AUTHOR("Santosh Yaragnavi <santosh.sy@samsung.com>"); MODULE_AUTHOR("Vinayak Holikatti <h.vinayak@samsung.com>"); MODULE_DESCRIPTION("Generic UFS host controller driver Core"); MODULE_LICENSE("GPL"); -MODULE_VERSION(UFSHCD_DRIVER_VERSION); diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index bb2624aabda2..49edbdb5ffd6 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -49,7 +49,6 @@ #include "ufshci.h" #define UFSHCD "ufshcd" -#define UFSHCD_DRIVER_VERSION "0.2" struct ufs_hba;
Driver version numbers are not useful in upstream kernel code. Hence remove the driver version number from the UFS driver. Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/ufs/cdns-pltfrm.c | 1 - drivers/scsi/ufs/ufshcd-pci.c | 1 - drivers/scsi/ufs/ufshcd-pltfrm.c | 1 - drivers/scsi/ufs/ufshcd.c | 1 - drivers/scsi/ufs/ufshcd.h | 1 - 5 files changed, 5 deletions(-)