| Message ID | 20220410163553.3501938-2-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: i2c: imx412: Add regulator control to imx412 | expand |
On 10/04/2022 18:35, Bryan O'Donoghue wrote: > The imx412 like many I2C camera sensors has three voltage rails which > depending on platform may be necessary to switch power onto directly. > > Add in as optional rails so as not to break anything for existing users. Thank you for your patch. There is something to discuss/improve. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/media/i2c/sony,imx412.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > index afcf70947f7e..16869a91ec9a 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > @@ -32,6 +32,18 @@ properties: > description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz > maxItems: 1 > > + dovdd-supply: > + description: > + Definition of the regulator used as interface power supply. > You could shorten this to "interface power supply", because other parts of the sentence do not describe the hardware more detailed. Similarly in other properties. An any case, looks good: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 10/04/2022 19:43, Krzysztof Kozlowski wrote:
> You could shorten this to "interface power supply"
np
I did a copy/paste from another DTS, I don't mind reformatting though
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml index afcf70947f7e..16869a91ec9a 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml @@ -32,6 +32,18 @@ properties: description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz maxItems: 1 + dovdd-supply: + description: + Definition of the regulator used as interface power supply. + + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + reset-gpios: description: Reference to the GPIO connected to the XCLR pin, if any. maxItems: 1
The imx412 like many I2C camera sensors has three voltage rails which depending on platform may be necessary to switch power onto directly. Add in as optional rails so as not to break anything for existing users. Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/media/i2c/sony,imx412.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)