[v4,01/12] dm: tag: change ENOSPC to ENOMEM

Message ID	20220415071546.122475-2-takahiro.akashi@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; From: AKASHI Takahiro <takahiro.akashi@linaro.org> To: xypron.glpk@gmx.de, sjg@chromium.org, ilias.apalodimas@linaro.org Cc: masami.hiramatsu@linaro.org, u-boot@lists.denx.de, AKASHI Takahiro <takahiro.akashi@linaro.org> Subject: [PATCH v4 01/12] dm: tag: change ENOSPC to ENOMEM Date: Fri, 15 Apr 2022 16:15:35 +0900 Message-Id: <20220415071546.122475-2-takahiro.akashi@linaro.org> In-Reply-To: <20220415071546.122475-1-takahiro.akashi@linaro.org> References: <20220415071546.122475-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	efi_loader: more tightly integrate UEFI disks to driver model \| expand [v4,00/12] efi_loader: more tightly integrate UEFI disks to driver model [v4,01/12] dm: tag: change ENOSPC to ENOMEM [v4,02/12] dm: tag: add some document [v4,03/12] test: dm: add tests for tag support [v4,04/12] dm: disk: add UCLASS_PARTITION [v4,05/12] dm: blk: add a device-probe hook for scanning disk partitions [v4,06/12] efi_loader: split efi_init_obj_list() into two stages [v4,07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice [v4,08/12] efi_loader: disk: not create BLK device for BLK(IF_TYPE_EFI_LOADER) devices [v4,09/12] efi_loader: disk: a helper function to delete efi_disk objects [v4,10/12] efi_loader: disk: not delete BLK device for BLK(IF_TYPE_EFI_LOADER) devices [v4,11/12] dm: disk: add read/write interfaces with udevice [v4,12/12] efi_loader: disk: use udevice instead of blk_desc

Message ID

20220415071546.122475-2-takahiro.akashi@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de
 designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61;
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: xypron.glpk@gmx.de,
	sjg@chromium.org,
	ilias.apalodimas@linaro.org
Cc: masami.hiramatsu@linaro.org, u-boot@lists.denx.de,
 AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: [PATCH v4 01/12] dm: tag: change ENOSPC to ENOMEM
Date: Fri, 15 Apr 2022 16:15:35 +0900
Message-Id: <20220415071546.122475-2-takahiro.akashi@linaro.org>
In-Reply-To: <20220415071546.122475-1-takahiro.akashi@linaro.org>
References: <20220415071546.122475-1-takahiro.akashi@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

efi_loader: more tightly integrate UEFI disks to driver model | expand

ENOMEM is a more common error code for memory starvation. Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- drivers/core/tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heinrich Schuchardt April 15, 2022, 7:59 a.m. UTC | #1

On 4/15/22 09:15, AKASHI Takahiro wrote:
> ENOMEM is a more common error code for memory starvation.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>   drivers/core/tag.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/core/tag.c b/drivers/core/tag.c
> index 6829bcd8806c..22999193a5a3 100644
> --- a/drivers/core/tag.c
> +++ b/drivers/core/tag.c
> @@ -29,7 +29,7 @@ int dev_tag_set_ptr(struct udevice *dev, enum dm_tag_t tag, void *ptr)
>
>   	node = calloc(sizeof(*node), 1);
>   	if (!node)
> -		return -ENOSPC;
> +		return -ENOMEM;
>
>   	node->dev = dev;
>   	node->tag = tag;
> @@ -53,7 +53,7 @@ int dev_tag_set_val(struct udevice *dev, enum dm_tag_t tag, ulong val)
>
>   	node = calloc(sizeof(*node), 1);
>   	if (!node)
> -		return -ENOSPC;
> +		return -ENOMEM;
>
>   	node->dev = dev;
>   	node->tag = tag;

Ilias Apalodimas April 15, 2022, 9:11 a.m. UTC | #2

On Fri, 15 Apr 2022 at 10:59, Heinrich Schuchardt <xypron.glpk@gmx.de>
wrote:

> On 4/15/22 09:15, AKASHI Takahiro wrote:
> > ENOMEM is a more common error code for memory starvation.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> >   drivers/core/tag.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/core/tag.c b/drivers/core/tag.c
> > index 6829bcd8806c..22999193a5a3 100644
> > --- a/drivers/core/tag.c
> > +++ b/drivers/core/tag.c
> > @@ -29,7 +29,7 @@ int dev_tag_set_ptr(struct udevice *dev, enum dm_tag_t
> tag, void *ptr)
> >
> >       node = calloc(sizeof(*node), 1);
> >       if (!node)
> > -             return -ENOSPC;
> > +             return -ENOMEM;
> >
> >       node->dev = dev;
> >       node->tag = tag;
> > @@ -53,7 +53,7 @@ int dev_tag_set_val(struct udevice *dev, enum dm_tag_t
> tag, ulong val)
> >
> >       node = calloc(sizeof(*node), 1);
> >       if (!node)
> > -             return -ENOSPC;
> > +             return -ENOMEM;
> >
> >       node->dev = dev;
> >       node->tag = tag;
>


Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/drivers/core/tag.c b/drivers/core/tag.c
index 6829bcd8806c..22999193a5a3 100644
--- a/drivers/core/tag.c
+++ b/drivers/core/tag.c
@@ -29,7 +29,7 @@  int dev_tag_set_ptr(struct udevice *dev, enum dm_tag_t tag, void *ptr)
 
 	node = calloc(sizeof(*node), 1);
 	if (!node)
-		return -ENOSPC;
+		return -ENOMEM;
 
 	node->dev = dev;
 	node->tag = tag;
@@ -53,7 +53,7 @@  int dev_tag_set_val(struct udevice *dev, enum dm_tag_t tag, ulong val)
 
 	node = calloc(sizeof(*node), 1);
 	if (!node)
-		return -ENOSPC;
+		return -ENOMEM;
 
 	node->dev = dev;
 	node->tag = tag;

[v4,01/12] dm: tag: change ENOSPC to ENOMEM

Commit Message

Comments

Patch