| Message ID | CADnVucD=LvKcUQcB0_zTPOsizqib151AF-k1M17m0yR3=DdOeA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On 11/11/15 12:08, Charles Baylis wrote: > On 11 November 2015 at 11:22, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: >> Hi Charles, >> >> On 08/11/15 00:26, charles.baylis@linaro.org wrote: >>> From: Charles Baylis <charles.baylis@linaro.org> >>> >>> <DATE> Charles Baylis <charles.baylis@linaro.org> >>> >>> * config/arm/neon.md (neon_vld1_lane<mode>): Remove error for >>> invalid >>> lane number. >>> (neon_vst1_lane<mode>): Likewise. >>> (neon_vld2_lane<mode>): Likewise. >>> (neon_vst2_lane<mode>): Likewise. >>> (neon_vld3_lane<mode>): Likewise. >>> (neon_vst3_lane<mode>): Likewise. >>> (neon_vld4_lane<mode>): Likewise. >>> (neon_vst4_lane<mode>): Likewise. >>> >> In this pattern the 'max' variable is now unused, causing a bootstrap >> -Werror failure on arm. >> I'll test a patch to fix it unless you beat me to it... > Thanks for catching this. > > I have a patch, and have started a bootstrap. Unless you have > objections, I'll apply as obvious once the bootstrap is complete later > this afternoon. Yes, that's the exact patch I'm testing as well. I'll let you finish the bootstrap and commit it. Thanks, Kyrill > > gcc/ChangeLog: > > 2015-11-11 Charles Baylis <charles.baylis@linaro.org> > > * config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max > variable. > (neon_vst2_lane<mode>): Likewise. > (neon_vld3_lane<mode>): Likewise. > (neon_vst3_lane<mode>): Likewise. > (neon_vld4_lane<mode>): Likewise. > (neon_vst4_lane<mode>): Likewise.
On 11 November 2015 at 12:10, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: > > On 11/11/15 12:08, Charles Baylis wrote: >> >> On 11 November 2015 at 11:22, Kyrill Tkachov <kyrylo.tkachov@arm.com> >> wrote: >>> >>> Hi Charles, >>> >>> On 08/11/15 00:26, charles.baylis@linaro.org wrote: >>>> >>>> From: Charles Baylis <charles.baylis@linaro.org> >>>> >>>> <DATE> Charles Baylis <charles.baylis@linaro.org> >>>> >>>> * config/arm/neon.md (neon_vld1_lane<mode>): Remove error for >>>> invalid >>>> lane number. >>>> (neon_vst1_lane<mode>): Likewise. >>>> (neon_vld2_lane<mode>): Likewise. >>>> (neon_vst2_lane<mode>): Likewise. >>>> (neon_vld3_lane<mode>): Likewise. >>>> (neon_vst3_lane<mode>): Likewise. >>>> (neon_vld4_lane<mode>): Likewise. >>>> (neon_vst4_lane<mode>): Likewise. >>>> >>> In this pattern the 'max' variable is now unused, causing a bootstrap >>> -Werror failure on arm. >>> I'll test a patch to fix it unless you beat me to it... >> >> Thanks for catching this. >> >> I have a patch, and have started a bootstrap. Unless you have >> objections, I'll apply as obvious once the bootstrap is complete later >> this afternoon. > > > Yes, that's the exact patch I'm testing as well. > I'll let you finish the bootstrap and commit it. >> gcc/ChangeLog: >> >> 2015-11-11 Charles Baylis <charles.baylis@linaro.org> >> >> * config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max >> variable. >> (neon_vst2_lane<mode>): Likewise. >> (neon_vld3_lane<mode>): Likewise. >> (neon_vst3_lane<mode>): Likewise. >> (neon_vld4_lane<mode>): Likewise. >> (neon_vst4_lane<mode>): Likewise. Applied as r230203 after successful bootstrap on arm-unknown-linux-gnueabihf.
From f111cb543bff0ad8756a0240f8bb1af1f19bbbbb Mon Sep 17 00:00:00 2001
From: Charles Baylis <charles.baylis@linaro.org>
Date: Wed, 11 Nov 2015 11:59:44 +0000
Subject: [PATCH] [ARM] remove unused variable
gcc/ChangeLog:
2015-11-11 Charles Baylis <charles.baylis@linaro.org>
* config/arm/neon.md: (neon_vld2_lane<mode>): Remove unused max
variable.
(neon_vst2_lane<mode>): Likewise.
(neon_vld3_lane<mode>): Likewise.
(neon_vst3_lane<mode>): Likewise.
(neon_vld4_lane<mode>): Likewise.
(neon_vst4_lane<mode>): Likewise.
Change-Id: Ifed53e2d4c5a581770848cab65cf2e8d1d9039c3
---
gcc/config/arm/neon.md | 6 ------
1 file changed, 6 deletions(-)
diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md
index 119550c..62fb6da 100644
--- a/gcc/config/arm/neon.md
+++ b/gcc/config/arm/neon.md
@@ -4464,7 +4464,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[3]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[0]);
rtx ops[4];
ops[0] = gen_rtx_REG (DImode, regno);
@@ -4579,7 +4578,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[2]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[1]);
rtx ops[4];
ops[0] = operands[0];
@@ -4723,7 +4721,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N (<MODE>mode, INTVAL (operands[3]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[0]);
rtx ops[5];
ops[0] = gen_rtx_REG (DImode, regno);
@@ -4895,7 +4892,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[2]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[1]);
rtx ops[5];
ops[0] = operands[0];
@@ -5045,7 +5041,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[3]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[0]);
rtx ops[6];
ops[0] = gen_rtx_REG (DImode, regno);
@@ -5225,7 +5220,6 @@ if (BYTES_BIG_ENDIAN)
"TARGET_NEON"
{
HOST_WIDE_INT lane = NEON_ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[2]));
- HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
int regno = REGNO (operands[1]);
rtx ops[6];
ops[0] = operands[0];
--
1.9.1