| Message ID | 20220421162640.302311-1-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: SOF: bump SOF_ABI_MINOR | expand |
On 4/21/2022 6:26 PM, Pierre-Louis Bossart wrote: > Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags") > did not update the SOF_ABI_MINOR, bump to version 20 before new > changes are added. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> > Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > --- > include/uapi/sound/sof/abi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/sound/sof/abi.h b/include/uapi/sound/sof/abi.h > index e052653a6e4cc..42227d4cb92c5 100644 > --- a/include/uapi/sound/sof/abi.h > +++ b/include/uapi/sound/sof/abi.h > @@ -26,7 +26,7 @@ > > /* SOF ABI version major, minor and patch numbers */ > #define SOF_ABI_MAJOR 3 > -#define SOF_ABI_MINOR 19 > +#define SOF_ABI_MINOR 20 > #define SOF_ABI_PATCH 1 > > /* SOF ABI version number. Format within 32bit word is MMmmmppp */ Seeing as you include hash id in commit message it should probably have Fixes tag, so if someone pulls the other commit they know to also back port this one?
On 4/22/22 02:38, Amadeusz Sławiński wrote: > On 4/21/2022 6:26 PM, Pierre-Louis Bossart wrote: >> Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags") >> did not update the SOF_ABI_MINOR, bump to version 20 before new >> changes are added. >> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> >> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> >> --- >> include/uapi/sound/sof/abi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/sound/sof/abi.h b/include/uapi/sound/sof/abi.h >> index e052653a6e4cc..42227d4cb92c5 100644 >> --- a/include/uapi/sound/sof/abi.h >> +++ b/include/uapi/sound/sof/abi.h >> @@ -26,7 +26,7 @@ >> /* SOF ABI version major, minor and patch numbers */ >> #define SOF_ABI_MAJOR 3 >> -#define SOF_ABI_MINOR 19 >> +#define SOF_ABI_MINOR 20 >> #define SOF_ABI_PATCH 1 >> /* SOF ABI version number. Format within 32bit word is MMmmmppp */ > > Seeing as you include hash id in commit message it should probably have Fixes tag, so if someone pulls the other commit they know to also back port this one? No, there's no need for a Fixes tag and backport, this is not really a functional issue. I added this patch to make a follow-up addition by Mediatek less confusing, in the initial version it came with two increments of the ABI version because of that earlier miss. see https://github.com/thesofproject/linux/pull/3353 for details.
On 4/21/22 11:26, Pierre-Louis Bossart wrote: > Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags") > did not update the SOF_ABI_MINOR, bump to version 20 before new > changes are added. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> > Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > --- > include/uapi/sound/sof/abi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/sound/sof/abi.h b/include/uapi/sound/sof/abi.h > index e052653a6e4cc..42227d4cb92c5 100644 > --- a/include/uapi/sound/sof/abi.h > +++ b/include/uapi/sound/sof/abi.h > @@ -26,7 +26,7 @@ > > /* SOF ABI version major, minor and patch numbers */ > #define SOF_ABI_MAJOR 3 > -#define SOF_ABI_MINOR 19 > +#define SOF_ABI_MINOR 20 > #define SOF_ABI_PATCH 1 Please don't merge this, the ABI_PATCH level should have been reset as well. Need new glasses. I will send a v2. > > /* SOF ABI version number. Format within 32bit word is MMmmmppp */
On Thu, 21 Apr 2022 11:26:40 -0500, Pierre-Louis Bossart wrote: > Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags") > did not update the SOF_ABI_MINOR, bump to version 20 before new > changes are added. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: bump SOF_ABI_MINOR commit: afe57ecab58b976c54fcbc31d718f936a0cc98cc All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/include/uapi/sound/sof/abi.h b/include/uapi/sound/sof/abi.h index e052653a6e4cc..42227d4cb92c5 100644 --- a/include/uapi/sound/sof/abi.h +++ b/include/uapi/sound/sof/abi.h @@ -26,7 +26,7 @@ /* SOF ABI version major, minor and patch numbers */ #define SOF_ABI_MAJOR 3 -#define SOF_ABI_MINOR 19 +#define SOF_ABI_MINOR 20 #define SOF_ABI_PATCH 1 /* SOF ABI version number. Format within 32bit word is MMmmmppp */
Commit a0f84dfb3f6d9 ("ASoC: SOF: IPC: dai: Expand DAI_CONFIG IPC flags") did not update the SOF_ABI_MINOR, bump to version 20 before new changes are added. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> --- include/uapi/sound/sof/abi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)