| Message ID | 20220422014430.55472-1-takahiro.akashi@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | cmd: part: add explicit dependency on PARTITIONS | expand |
On Fri, Apr 22, 2022 at 10:44:30AM +0900, AKASHI Takahiro wrote: > This is a follow-up patch for my "disk: don't compile in partition > support for spl/tpl if not really necessary". > > "part" command is useful only if, at least, one of partition table types > is selected. So it should have a dependency on PARTITIONS which is now > automatically selected if one of partition table types is enabled. > > With this change, *_defconfig which explicitly selects CMD_PART but > has no partition table types enabled should also be fixed. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> Reviewed-by: Tom Rini <trini@konsulko.com>
On Fri, Apr 22, 2022 at 10:44:30AM +0900, AKASHI Takahiro wrote: > This is a follow-up patch for my "disk: don't compile in partition > support for spl/tpl if not really necessary". > > "part" command is useful only if, at least, one of partition table types > is selected. So it should have a dependency on PARTITIONS which is now > automatically selected if one of partition table types is enabled. > > With this change, *_defconfig which explicitly selects CMD_PART but > has no partition table types enabled should also be fixed. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index d3abe3a06bff..b69c26912568 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1239,6 +1239,7 @@ config CMD_OSD config CMD_PART bool "part" + depends on PARTITIONS select HAVE_BLOCK_DEVICE select PARTITION_UUIDS help diff --git a/configs/cortina_presidio-asic-emmc_defconfig b/configs/cortina_presidio-asic-emmc_defconfig index c22dcef7ec05..c217a00a1cf0 100644 --- a/configs/cortina_presidio-asic-emmc_defconfig +++ b/configs/cortina_presidio-asic-emmc_defconfig @@ -18,7 +18,6 @@ CONFIG_LAST_STAGE_INIT=y CONFIG_SYS_PROMPT="G3#" CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_PART=y CONFIG_CMD_WDT=y CONFIG_BOOTP_BOOTFILESIZE=y CONFIG_CMD_CACHE=y
This is a follow-up patch for my "disk: don't compile in partition support for spl/tpl if not really necessary". "part" command is useful only if, at least, one of partition table types is selected. So it should have a dependency on PARTITIONS which is now automatically selected if one of partition table types is enabled. With this change, *_defconfig which explicitly selects CMD_PART but has no partition table types enabled should also be fixed. Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- cmd/Kconfig | 1 + configs/cortina_presidio-asic-emmc_defconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)