| Message ID | 20220425221802.68498-1-ilkka@os.amperecomputing.com |
|---|---|
| State | Accepted |
| Commit | 988d7a14408db4183202f16bb02b8149b9da3727 |
| Headers | show |
| Series | ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init() | expand |
On Tue, Apr 26, 2022 at 12:18 AM Ilkka Koskinen <ilkka@os.amperecomputing.com> wrote: > > When building with W=1, we get the following warning: > > drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes] > void __init acpi_agdi_init(void) > > Include AGDI driver's header file to pull in the prototype definition > for acpi_agdi_init() to get rid of the compiler warning > > Fixes: a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> > --- > drivers/acpi/arm64/agdi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c > index 4df337d545b7..cf31abd0ed1b 100644 > --- a/drivers/acpi/arm64/agdi.c > +++ b/drivers/acpi/arm64/agdi.c > @@ -9,6 +9,7 @@ > #define pr_fmt(fmt) "ACPI: AGDI: " fmt > > #include <linux/acpi.h> > +#include <linux/acpi_agdi.h> > #include <linux/arm_sdei.h> > #include <linux/io.h> > #include <linux/kernel.h> > -- Applied as 5.19 material, thanks!
diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c index 4df337d545b7..cf31abd0ed1b 100644 --- a/drivers/acpi/arm64/agdi.c +++ b/drivers/acpi/arm64/agdi.c @@ -9,6 +9,7 @@ #define pr_fmt(fmt) "ACPI: AGDI: " fmt #include <linux/acpi.h> +#include <linux/acpi_agdi.h> #include <linux/arm_sdei.h> #include <linux/io.h> #include <linux/kernel.h>
When building with W=1, we get the following warning: drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes] void __init acpi_agdi_init(void) Include AGDI driver's header file to pull in the prototype definition for acpi_agdi_init() to get rid of the compiler warning Fixes: a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> --- drivers/acpi/arm64/agdi.c | 1 + 1 file changed, 1 insertion(+)