diff mbox

[1/2] helper/hashtable.c: remove unused variable

Message ID 1447696984-15744-1-git-send-email-anders.roxell@linaro.org
State Accepted
Commit 9be179223ffe4fdda3e8bd73c4ffe712a0b19574
Headers show

Commit Message

Anders Roxell Nov. 16, 2015, 6:03 p.m. UTC
hashtable.c: In function 'odph_hash_table_create':
hashtable.c:68:6: warning: unused variable 'idx' [-Wunused-variable]
  int idx, i;
      ^
hashtable.c: In function 'odph_hash_table_lookup':
hashtable.c:151:6: warning: unused variable 'idx' [-Wunused-variable]
  int idx;
      ^

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 helper/hashtable.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mike Holmes Nov. 16, 2015, 9:56 p.m. UTC | #1
On 16 November 2015 at 13:03, Anders Roxell <anders.roxell@linaro.org>
wrote:

> hashtable.c: In function 'odph_hash_table_create':

> hashtable.c:68:6: warning: unused variable 'idx' [-Wunused-variable]

>   int idx, i;

>       ^

> hashtable.c: In function 'odph_hash_table_lookup':

> hashtable.c:151:6: warning: unused variable 'idx' [-Wunused-variable]

>   int idx;

>       ^

>

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>


For series

Reviewed-by: Mike Holmes <mike.holmes@linaro.org>



> ---

>  helper/hashtable.c | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/helper/hashtable.c b/helper/hashtable.c

> index 0b29814..1121beb 100644

> --- a/helper/hashtable.c

> +++ b/helper/hashtable.c

> @@ -65,7 +65,7 @@ odph_table_t odph_hash_table_create(const char *name,

> uint32_t capacity,

>                                     uint32_t key_size,

>                                     uint32_t value_size)

>  {

> -       int idx, i;

> +       int i;

>         uint32_t node_num;

>         odph_hash_table_imp *tbl;

>         odp_shm_t shmem;

> @@ -148,7 +148,6 @@ int odph_hash_table_destroy(odph_table_t table)

>

>  odph_table_t odph_hash_table_lookup(const char *name)

>  {

> -       int idx;

>         odph_hash_table_imp *hash_tbl;

>

>         if (name == NULL || strlen(name) >= ODPH_TABLE_NAME_LEN)

> --

> 2.1.4

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
Maxim Uvarov Nov. 18, 2015, 10:09 a.m. UTC | #2
Merged,
Maxim.

On 11/17/2015 00:56, Mike Holmes wrote:
>
>
> On 16 November 2015 at 13:03, Anders Roxell <anders.roxell@linaro.org 
> <mailto:anders.roxell@linaro.org>> wrote:
>
>     hashtable.c: In function 'odph_hash_table_create':
>     hashtable.c:68:6: warning: unused variable 'idx' [-Wunused-variable]
>       int idx, i;
>           ^
>     hashtable.c: In function 'odph_hash_table_lookup':
>     hashtable.c:151:6: warning: unused variable 'idx' [-Wunused-variable]
>       int idx;
>           ^
>
>     Signed-off-by: Anders Roxell <anders.roxell@linaro.org
>     <mailto:anders.roxell@linaro.org>>
>
>
> For series
>
> Reviewed-by: Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>>
>
>     ---
>      helper/hashtable.c | 3 +--
>      1 file changed, 1 insertion(+), 2 deletions(-)
>
>     diff --git a/helper/hashtable.c b/helper/hashtable.c
>     index 0b29814..1121beb 100644
>     --- a/helper/hashtable.c
>     +++ b/helper/hashtable.c
>     @@ -65,7 +65,7 @@ odph_table_t odph_hash_table_create(const char
>     *name, uint32_t capacity,
>                                         uint32_t key_size,
>                                         uint32_t value_size)
>      {
>     -       int idx, i;
>     +       int i;
>             uint32_t node_num;
>             odph_hash_table_imp *tbl;
>             odp_shm_t shmem;
>     @@ -148,7 +148,6 @@ int odph_hash_table_destroy(odph_table_t table)
>
>      odph_table_t odph_hash_table_lookup(const char *name)
>      {
>     -       int idx;
>             odph_hash_table_imp *hash_tbl;
>
>             if (name == NULL || strlen(name) >= ODPH_TABLE_NAME_LEN)
>     --
>     2.1.4
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> -- 
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/helper/hashtable.c b/helper/hashtable.c
index 0b29814..1121beb 100644
--- a/helper/hashtable.c
+++ b/helper/hashtable.c
@@ -65,7 +65,7 @@  odph_table_t odph_hash_table_create(const char *name, uint32_t capacity,
 				    uint32_t key_size,
 				    uint32_t value_size)
 {
-	int idx, i;
+	int i;
 	uint32_t node_num;
 	odph_hash_table_imp *tbl;
 	odp_shm_t shmem;
@@ -148,7 +148,6 @@  int odph_hash_table_destroy(odph_table_t table)
 
 odph_table_t odph_hash_table_lookup(const char *name)
 {
-	int idx;
 	odph_hash_table_imp *hash_tbl;
 
 	if (name == NULL || strlen(name) >= ODPH_TABLE_NAME_LEN)