diff mbox series

[bluetooth-next,1/3] net: 6lowpan: remove const from scalars

Message ID 20220428030534.3220410-2-aahringo@redhat.com
State Accepted
Commit eb9edf4366a2364b626c000b9ac720b0c13a551c
Headers show
Series net: 6lowpan: simplify lookup by nhc id | expand

Commit Message

Alexander Aring April 28, 2022, 3:05 a.m. UTC
The keyword const makes no sense for scalar types inside the lowpan_nhc
structure. Most compilers will ignore it so we remove the keyword from
the scalar types.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 net/6lowpan/nhc.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stefan Schmidt May 2, 2022, 7:36 p.m. UTC | #1
Hello.

On 28.04.22 05:05, Alexander Aring wrote:
> The keyword const makes no sense for scalar types inside the lowpan_nhc
> structure. Most compilers will ignore it so we remove the keyword from
> the scalar types.
> 
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>   net/6lowpan/nhc.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
> index 67951c40734b..2ac7da388c4d 100644
> --- a/net/6lowpan/nhc.h
> +++ b/net/6lowpan/nhc.h
> @@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
>   struct lowpan_nhc {
>   	struct rb_node	node;
>   	const char	*name;
> -	const u8	nexthdr;
> -	const size_t	nexthdrlen;
> +	u8		nexthdr;
> +	size_t		nexthdrlen;
>   	u8		*id;
>   	u8		*idmask;
> -	const size_t	idlen;
> +	size_t		idlen;
>   
>   	void		(*idsetup)(struct lowpan_nhc *nhc);
>   	int		(*uncompress)(struct sk_buff *skb, size_t needed);

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>

regards
Stefan Schmidt
Jukka Rissanen May 3, 2022, 7:31 a.m. UTC | #2
On Wed, 2022-04-27 at 23:05 -0400, Alexander Aring wrote:
> The keyword const makes no sense for scalar types inside the
> lowpan_nhc
> structure. Most compilers will ignore it so we remove the keyword
> from
> the scalar types.
> 
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>  net/6lowpan/nhc.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
> index 67951c40734b..2ac7da388c4d 100644
> --- a/net/6lowpan/nhc.h
> +++ b/net/6lowpan/nhc.h
> @@ -67,11 +67,11 @@ module_exit(__nhc##_exit);
>  struct lowpan_nhc {
>         struct rb_node  node;
>         const char      *name;
> -       const u8        nexthdr;
> -       const size_t    nexthdrlen;
> +       u8              nexthdr;
> +       size_t          nexthdrlen;
>         u8              *id;
>         u8              *idmask;
> -       const size_t    idlen;
> +       size_t          idlen;
>  
>         void            (*idsetup)(struct lowpan_nhc *nhc);
>         int             (*uncompress)(struct sk_buff *skb, size_t
> needed);


Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>


Cheers,
Jukka
diff mbox series

Patch

diff --git a/net/6lowpan/nhc.h b/net/6lowpan/nhc.h
index 67951c40734b..2ac7da388c4d 100644
--- a/net/6lowpan/nhc.h
+++ b/net/6lowpan/nhc.h
@@ -67,11 +67,11 @@  module_exit(__nhc##_exit);
 struct lowpan_nhc {
 	struct rb_node	node;
 	const char	*name;
-	const u8	nexthdr;
-	const size_t	nexthdrlen;
+	u8		nexthdr;
+	size_t		nexthdrlen;
 	u8		*id;
 	u8		*idmask;
-	const size_t	idlen;
+	size_t		idlen;
 
 	void		(*idsetup)(struct lowpan_nhc *nhc);
 	int		(*uncompress)(struct sk_buff *skb, size_t needed);