| Message ID | 20220428070245.255827-1-zhangxuezhi1@coolpad.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: pmcraid: convert sysfs snprintf to sysfs_emit | expand |
Xuezhi, > @@ -3554,8 +3554,7 @@ static ssize_t pmcraid_show_drv_version( > char *buf > ) > { > - return snprintf(buf, PAGE_SIZE, "version: %s\n", > - PMCRAID_DRIVER_VERSION); > + return sysfs_emt(buf, "version: %s\n", PMCRAID_DRIVER_VERSION); ^^^^^^^^^
On 4/28/22 00:02, Xuezhi Zhang wrote: > Fix the following coccicheck warnings: > drivers/scsi/pmcraid.c:3591:8-16: > WARNING: use scnprintf or sprintf > drivers/scsi/pmcraid.c:3557:8-16: > WARNING: use scnprintf or sprintf > drivers/scsi/pmcraid.c:3496:8-16: > WARNING: use scnprintf or sprintf I'm not sure the above is sufficient as motivation for this patch. The current code looks fine to me. Why to change the snprintf() calls into sysfs_emit() calls? > @@ -3554,8 +3554,7 @@ static ssize_t pmcraid_show_drv_version( > char *buf > ) > { > - return snprintf(buf, PAGE_SIZE, "version: %s\n", > - PMCRAID_DRIVER_VERSION); > + return sysfs_emt(buf, "version: %s\n", PMCRAID_DRIVER_VERSION); > } Something tells me that this patch has not been tested at all - not even compile tested. Are you perhaps checking whether it is possible to get a broken patch in the kernel tree? Bart.
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 3d5cd337a2a6..299553ff2277 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3493,7 +3493,7 @@ static ssize_t pmcraid_show_log_level( struct Scsi_Host *shost = class_to_shost(dev); struct pmcraid_instance *pinstance = (struct pmcraid_instance *)shost->hostdata; - return snprintf(buf, PAGE_SIZE, "%d\n", pinstance->current_log_level); + return sysfs_emit(buf, "%d\n", pinstance->current_log_level); } /** @@ -3554,8 +3554,7 @@ static ssize_t pmcraid_show_drv_version( char *buf ) { - return snprintf(buf, PAGE_SIZE, "version: %s\n", - PMCRAID_DRIVER_VERSION); + return sysfs_emt(buf, "version: %s\n", PMCRAID_DRIVER_VERSION); } static struct device_attribute pmcraid_driver_version_attr = { @@ -3588,8 +3587,7 @@ static ssize_t pmcraid_show_adapter_id( pinstance->pdev->devfn; u32 aen_group = pmcraid_event_family.id; - return snprintf(buf, PAGE_SIZE, - "adapter id: %d\nminor: %d\naen group: %d\n", + return sysfs_emit(buf, "adapter id: %d\nminor: %d\naen group: %d\n", adapter_id, MINOR(pinstance->cdev.dev), aen_group); }
Fix the following coccicheck warnings: drivers/scsi/pmcraid.c:3591:8-16: WARNING: use scnprintf or sprintf drivers/scsi/pmcraid.c:3557:8-16: WARNING: use scnprintf or sprintf drivers/scsi/pmcraid.c:3496:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> --- drivers/scsi/pmcraid.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)