| Message ID | 20220507153627.1478268-1-marijn.suijten@somainline.org |
|---|---|
| State | Accepted |
| Commit | 2aa54fa87cca1fa43870a9caf4fcce00eb087fa5 |
| Headers | show |
| Series | arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size | expand |
On 7.05.2022 17:36, Marijn Suijten wrote: > These voltages are not a multiple of the given step-size 8000 (with base > voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and > l22 failing to validate and in turn not probing the rpm-pm8998-regulator > driver: > > l18: unsupportable voltage constraints 2856000-2848000uV > qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22 > > Round the voltages down for the sake of erring on the safe side, leaving > a comment in place to document this discrepancy wrt downstream sources. > > Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform") > Reported-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- Also: Reported-by: Markuss Broks <markuss.broks@gmail.com> Konrad > .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts > index 4a1f98a21031..c21333aa73c2 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts > +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts > @@ -26,11 +26,13 @@ &lab { > }; > > &vreg_l18a_2p85 { > - regulator-min-microvolt = <2850000>; > - regulator-max-microvolt = <2850000>; > + /* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */ > + regulator-min-microvolt = <2848000>; > + regulator-max-microvolt = <2848000>; > }; > > &vreg_l22a_2p85 { > - regulator-min-microvolt = <2700000>; > - regulator-max-microvolt = <2700000>; > + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */ > + regulator-min-microvolt = <2696000>; > + regulator-max-microvolt = <2696000>; > };
On Sat, 7 May 2022 17:36:27 +0200, Marijn Suijten wrote: > These voltages are not a multiple of the given step-size 8000 (with base > voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and > l22 failing to validate and in turn not probing the rpm-pm8998-regulator > driver: > > l18: unsupportable voltage constraints 2856000-2848000uV > qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22 > > [...] Applied, thanks! [1/1] arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size commit: 2aa54fa87cca1fa43870a9caf4fcce00eb087fa5 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts index 4a1f98a21031..c21333aa73c2 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts @@ -26,11 +26,13 @@ &lab { }; &vreg_l18a_2p85 { - regulator-min-microvolt = <2850000>; - regulator-max-microvolt = <2850000>; + /* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */ + regulator-min-microvolt = <2848000>; + regulator-max-microvolt = <2848000>; }; &vreg_l22a_2p85 { - regulator-min-microvolt = <2700000>; - regulator-max-microvolt = <2700000>; + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */ + regulator-min-microvolt = <2696000>; + regulator-max-microvolt = <2696000>; };
These voltages are not a multiple of the given step-size 8000 (with base voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and l22 failing to validate and in turn not probing the rpm-pm8998-regulator driver: l18: unsupportable voltage constraints 2856000-2848000uV qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22 Round the voltages down for the sake of erring on the safe side, leaving a comment in place to document this discrepancy wrt downstream sources. Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform") Reported-by: Konrad Dybcio <konrad.dybcio@somainline.org> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)