| Message ID | 20220510082029.197841-1-guanjing6@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] usb: dwc3: include extcon.h to fix compile error | expand |
On Wed, May 11, 2022 at 10:05:56AM +0800, guanjing (D) wrote: > Thanks for your reply, when CONFIG_EXTCON is "m", we will see these build > error. > > > Fixes: 0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is > present") > > > I have pasted the config file in the attachment. Your .config builds just fine for me here. Are you sure you are working with a clean tree? thanks, greg k-h
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 950e238c65bf..ea7259443283 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -33,6 +33,7 @@ #include <linux/usb/gadget.h> #include <linux/usb/of.h> #include <linux/usb/otg.h> +#include <linux/extcon.h> #include "core.h" #include "gadget.h"
If dwc3 is not include extcon.h, the dwc3 driver will fail to link: drivers/usb/dwc3/core.o: In function `dwc3_probe': core.c:(.text+0x1095): undefined reference to `extcon_get_edev_by_phandle' core.c:(.text+0x10bd): undefined reference to `extcon_get_extcon_dev' Add miss #include <linux/extcon.h> to fix this error. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Guan Jing <guanjing6@huawei.com> --- drivers/usb/dwc3/core.c | 1 + 1 file changed, 1 insertion(+)