| Message ID | 20220512173921.8210-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | bdb6528ec5504ccc5a9da768a406579e7670dd2b |
| Headers | show |
| Series | [v1,1/5] Documentation: gpio: Fix IRQ mask and unmask examples | expand |
On Thu, May 12, 2022 at 7:52 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > After switching to immutable IRQ chips for GPIO drivers the examples become > uncompilable due to wrong IRQ API, i.e. irq_desc_get_handler_data() in use. > Replace it with proper irq_data_get_irq_chip_data() call where it applies. > > Fixes: 5644b66a9c63 ("Documentation: Update the recommended pattern for GPIO irqchips") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, May 13, 2022 at 10:54:46PM +0200, Linus Walleij wrote: > On Thu, May 12, 2022 at 7:52 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > After switching to immutable IRQ chips for GPIO drivers the examples become > > uncompilable due to wrong IRQ API, i.e. irq_desc_get_handler_data() in use. > > Replace it with proper irq_data_get_irq_chip_data() call where it applies. > > > > Fixes: 5644b66a9c63 ("Documentation: Update the recommended pattern for GPIO irqchips") > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Entire series with the respective tags has been pushed to my review and testing queue, thanks!
diff --git a/Documentation/driver-api/gpio/driver.rst b/Documentation/driver-api/gpio/driver.rst index a1ddefa1f55f..964d09118d17 100644 --- a/Documentation/driver-api/gpio/driver.rst +++ b/Documentation/driver-api/gpio/driver.rst @@ -429,7 +429,7 @@ call into the core gpiolib code: static void my_gpio_mask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); /* * Perform any necessary action to mask the interrupt, @@ -442,7 +442,7 @@ call into the core gpiolib code: static void my_gpio_unmask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); gpiochip_enable_irq(gc, d->hwirq); @@ -501,7 +501,7 @@ the interrupt separately and go with it: static void my_gpio_mask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); /* * Perform any necessary action to mask the interrupt, @@ -514,7 +514,7 @@ the interrupt separately and go with it: static void my_gpio_unmask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); gpiochip_enable_irq(gc, d->hwirq); @@ -576,7 +576,7 @@ In this case the typical set-up will look like this: static void my_gpio_mask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); /* * Perform any necessary action to mask the interrupt, @@ -590,7 +590,7 @@ In this case the typical set-up will look like this: static void my_gpio_unmask_irq(struct irq_data *d) { - struct gpio_chip *gc = irq_desc_get_handler_data(d); + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); gpiochip_enable_irq(gc, d->hwirq);
After switching to immutable IRQ chips for GPIO drivers the examples become uncompilable due to wrong IRQ API, i.e. irq_desc_get_handler_data() in use. Replace it with proper irq_data_get_irq_chip_data() call where it applies. Fixes: 5644b66a9c63 ("Documentation: Update the recommended pattern for GPIO irqchips") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- Documentation/driver-api/gpio/driver.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)