| Message ID | 1652857340-6040-5-git-send-email-quic_c_sbhanu@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mmc: add error statistics for eMMC and SD card | expand |
On 18/05/22 10:02, Shaik Sajida Bhanu wrote: > Add debug fs entry error state to query eMMC and SD card errors statistics. > If any errors occurred in eMMC and SD card driver level then > err_state value will be set to 1. > > Signed-off-by: Liangliang Lu <quic_luliang@quicinc.com> > Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> > Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com> > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> Could use debugfs_create_file_unsafe() (see below) Otherwise: Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/core/debugfs.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c > index 6aa5a60..3c7908d 100644 > --- a/drivers/mmc/core/debugfs.c > +++ b/drivers/mmc/core/debugfs.c > @@ -223,6 +223,27 @@ static int mmc_clock_opt_set(void *data, u64 val) > DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, > "%llu\n"); > > +static int mmc_err_state_get(void *data, u64 *val) > +{ > + struct mmc_host *host = data; > + int i; > + > + if (!host) > + return -EINVAL; > + > + *val = 0; > + for (i = 0; i < MMC_ERR_MAX; i++) { > + if (host->err_stats[i]) { > + *val = 1; > + break; > + } > + } > + > + return 0; > +} > + > +DEFINE_DEBUGFS_ATTRIBUTE(mmc_err_state, mmc_err_state_get, NULL, "%llu\n"); > + > static int mmc_err_stats_show(struct seq_file *file, void *data) > { > struct mmc_host *host = (struct mmc_host *)file->private; > @@ -289,6 +310,8 @@ void mmc_add_host_debugfs(struct mmc_host *host) > debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host, > &mmc_clock_fops); > > + debugfs_create_file("err_state", 0600, root, host, > + &mmc_err_state); This could use debugfs_create_file_unsafe() > debugfs_create_file("err_stats", 0600, root, host, > &mmc_err_stats_fops); >
Hi Adrian, Thanks for the review. Please find the inline comments. Thanks, Sajida On 5/23/2022 12:45 PM, Adrian Hunter wrote: > On 18/05/22 10:02, Shaik Sajida Bhanu wrote: >> Add debug fs entry error state to query eMMC and SD card errors statistics. >> If any errors occurred in eMMC and SD card driver level then >> err_state value will be set to 1. >> >> Signed-off-by: Liangliang Lu <quic_luliang@quicinc.com> >> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> >> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com> >> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> > Could use debugfs_create_file_unsafe() (see below) > > Otherwise: > > Acked-by: Adrian Hunter <adrian.hunter@intel.com> Sure Thank you > >> --- >> drivers/mmc/core/debugfs.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c >> index 6aa5a60..3c7908d 100644 >> --- a/drivers/mmc/core/debugfs.c >> +++ b/drivers/mmc/core/debugfs.c >> @@ -223,6 +223,27 @@ static int mmc_clock_opt_set(void *data, u64 val) >> DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, >> "%llu\n"); >> >> +static int mmc_err_state_get(void *data, u64 *val) >> +{ >> + struct mmc_host *host = data; >> + int i; >> + >> + if (!host) >> + return -EINVAL; >> + >> + *val = 0; >> + for (i = 0; i < MMC_ERR_MAX; i++) { >> + if (host->err_stats[i]) { >> + *val = 1; >> + break; >> + } >> + } >> + >> + return 0; >> +} >> + >> +DEFINE_DEBUGFS_ATTRIBUTE(mmc_err_state, mmc_err_state_get, NULL, "%llu\n"); >> + >> static int mmc_err_stats_show(struct seq_file *file, void *data) >> { >> struct mmc_host *host = (struct mmc_host *)file->private; >> @@ -289,6 +310,8 @@ void mmc_add_host_debugfs(struct mmc_host *host) >> debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host, >> &mmc_clock_fops); >> >> + debugfs_create_file("err_state", 0600, root, host, >> + &mmc_err_state); > This could use debugfs_create_file_unsafe() Sure > >> debugfs_create_file("err_stats", 0600, root, host, >> &mmc_err_stats_fops); >>
diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 6aa5a60..3c7908d 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -223,6 +223,27 @@ static int mmc_clock_opt_set(void *data, u64 val) DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, "%llu\n"); +static int mmc_err_state_get(void *data, u64 *val) +{ + struct mmc_host *host = data; + int i; + + if (!host) + return -EINVAL; + + *val = 0; + for (i = 0; i < MMC_ERR_MAX; i++) { + if (host->err_stats[i]) { + *val = 1; + break; + } + } + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(mmc_err_state, mmc_err_state_get, NULL, "%llu\n"); + static int mmc_err_stats_show(struct seq_file *file, void *data) { struct mmc_host *host = (struct mmc_host *)file->private; @@ -289,6 +310,8 @@ void mmc_add_host_debugfs(struct mmc_host *host) debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host, &mmc_clock_fops); + debugfs_create_file("err_state", 0600, root, host, + &mmc_err_state); debugfs_create_file("err_stats", 0600, root, host, &mmc_err_stats_fops);