| Message ID | 20220523204337.19739-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] drm/msm: DRM_DP_AUX_BUS depends on OF | expand |
Hi, On Mon, 23 May 2022 at 23:43, Randy Dunlap <rdunlap@infradead.org> wrote: > > Fix a Kconfig warning for DRM_MSM by making it depend on OF, > since 'select' does not follow any dependency chaings. > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS I think it was agreed that DRM_DP_AUX_BUS should depend on OF || COMPILE_TEST (and the patch has been submitted by YueHaibing). See the thread at https://lore.kernel.org/dri-devel/9534934e-4c4a-ba2f-3bc3-d6d241e625bb@linaro.org/T/ > Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && OF [=n] > Selected by [m]: > - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -3,6 +3,7 @@ > config DRM_MSM > tristate "MSM DRM" > depends on DRM > + depends on OF > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > depends on COMMON_CLK > depends on IOMMU_SUPPORT
On 5/23/22 15:23, Dmitry Baryshkov wrote: > Hi, > > On Mon, 23 May 2022 at 23:43, Randy Dunlap <rdunlap@infradead.org> wrote: >> >> Fix a Kconfig warning for DRM_MSM by making it depend on OF, >> since 'select' does not follow any dependency chaings. >> >> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > I think it was agreed that DRM_DP_AUX_BUS should depend on OF || > COMPILE_TEST (and the patch has been submitted by YueHaibing). See the > thread at https://lore.kernel.org/dri-devel/9534934e-4c4a-ba2f-3bc3-d6d241e625bb@linaro.org/T/ > I see. Thanks. > >> Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && OF [=n] >> Selected by [m]: >> - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) >> >> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Rob Clark <robdclark@gmail.com> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Sean Paul <sean@poorly.run> >> Cc: linux-arm-msm@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: freedreno@lists.freedesktop.org >> Cc: David Airlie <airlied@linux.ie> >> Cc: Daniel Vetter <daniel@ffwll.ch> >> --- >> drivers/gpu/drm/msm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -3,6 +3,7 @@ >> config DRM_MSM >> tristate "MSM DRM" >> depends on DRM >> + depends on OF >> depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST >> depends on COMMON_CLK >> depends on IOMMU_SUPPORT > > >
--- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -3,6 +3,7 @@ config DRM_MSM tristate "MSM DRM" depends on DRM + depends on OF depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on COMMON_CLK depends on IOMMU_SUPPORT
Fix a Kconfig warning for DRM_MSM by making it depend on OF, since 'select' does not follow any dependency chaings. WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && OF [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+)