| Message ID | d9c9889ac01bf5656e0902ad369e8811c44c3e0c.1653222646.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | New |
| Headers | show |
| Series | bus: qcom-ssc-block-bus: Fix resource release in .remove function | expand |
Le 22/05/2022 à 14:31, Christophe JAILLET a écrit : > These resources are allocated using devm_ioremap_resource(), so there is no > need to call iounmap() explicitly. > > Fixes: 97d485edc1d9 ("bus: add driver for initializing the SSC bus on (some) qcom SoCs") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/bus/qcom-ssc-block-bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c > index eedeb29a5ff3..eaa39e08dd96 100644 > --- a/drivers/bus/qcom-ssc-block-bus.c > +++ b/drivers/bus/qcom-ssc-block-bus.c > @@ -356,9 +356,6 @@ static int qcom_ssc_block_bus_remove(struct platform_device *pdev) > > qcom_ssc_block_bus_deinit(&pdev->dev); > > - iounmap(data->reg_mpm_sscaon_config0); > - iounmap(data->reg_mpm_sscaon_config1); > - > qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds); > qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds); > pm_runtime_disable(&pdev->dev); Hi, polite reminder, with updated list from get_maintainer.pl CJ
diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c index eedeb29a5ff3..eaa39e08dd96 100644 --- a/drivers/bus/qcom-ssc-block-bus.c +++ b/drivers/bus/qcom-ssc-block-bus.c @@ -356,9 +356,6 @@ static int qcom_ssc_block_bus_remove(struct platform_device *pdev) qcom_ssc_block_bus_deinit(&pdev->dev); - iounmap(data->reg_mpm_sscaon_config0); - iounmap(data->reg_mpm_sscaon_config1); - qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds); qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds); pm_runtime_disable(&pdev->dev);
These resources are allocated using devm_ioremap_resource(), so there is no need to call iounmap() explicitly. Fixes: 97d485edc1d9 ("bus: add driver for initializing the SSC bus on (some) qcom SoCs") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/bus/qcom-ssc-block-bus.c | 3 --- 1 file changed, 3 deletions(-)