| Message ID | 20220526094100.1494193-1-jiasheng@iscas.ac.cn |
|---|---|
| State | Accepted |
| Commit | 6ba12b56b9b844b83ed54fb7ed59fb0eb41e4045 |
| Headers | show |
| Series | i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register | expand |
On Thu, May 26, 2022 at 05:41:00PM +0800, Jiasheng Jiang wrote: > As platform_driver_register() could fail, it should be better > to deal with the return value in order to maintain the code > consisitency. > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Applied to for-current, thanks! But what is with the "barco-p50-gpio:" in the $subject?
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index 71aad029425d..08737fa2dcbf 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -2336,8 +2336,7 @@ static struct platform_driver npcm_i2c_bus_driver = { static int __init npcm_i2c_init(void) { npcm_i2c_debugfs_dir = debugfs_create_dir("npcm_i2c", NULL); - platform_driver_register(&npcm_i2c_bus_driver); - return 0; + return platform_driver_register(&npcm_i2c_bus_driver); } module_init(npcm_i2c_init);
As platform_driver_register() could fail, it should be better to deal with the return value in order to maintain the code consisitency. Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/i2c/busses/i2c-npcm7xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)