| Message ID | 1654169206-12255-2-git-send-email-quic_srivasam@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Update external mclk name | expand |
On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote: > On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote: > > Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0", > > as MI2S mclk is being used is from lpass core cc. > This is safe to change breaking the ABI because ... The driver was only just merged so didn't make it into a full release. > Names are supposed to be local to the module, not based on their source. Indeed.
On 6/2/2022 8:10 PM, Mark Brown wrote: Thanks for your time Mark Brown and Rob Herring!!! > On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote: >> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote: >>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0", >>> as MI2S mclk is being used is from lpass core cc. >> This is safe to change breaking the ABI because ... > The driver was only just merged so didn't make it into a full > release. yes. DTS changes are still in review state. > >> Names are supposed to be local to the module, not based on their source. > Indeed. Okay. Will take care next time. As external MCLK is supported from both modules, audio cc and core cc, for now it's mandatory to change the name to avoid confusion.
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml index e9a5330..8438ef77 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml @@ -195,7 +195,7 @@ allOf: oneOf: - items: #for I2S - const: aon_cc_audio_hm_h - - const: audio_cc_ext_mclk0 + - const: core_cc_ext_mclk0 - const: core_cc_sysnoc_mport_core - const: core_cc_ext_if0_ibit - const: core_cc_ext_if1_ibit
Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0", as MI2S mclk is being used is from lpass core cc. Fixes: 98b7630a583f ("ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform") Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> --- Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)