| Message ID | 20220603131043.38907-1-linmq006@gmail.com |
|---|---|
| State | Accepted |
| Commit | 0a034d93ee929a9ea89f3fa5f1d8492435b9ee6e |
| Headers | show |
| Series | [v2] ASoC: cros_ec_codec: Fix refcount leak in cros_ec_codec_platform_probe | expand |
On Fri, Jun 3, 2022 at 6:11 AM Miaoqian Lin <linmq006@gmail.com> wrote: > > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b6bc07d4360d ("ASoC: cros_ec_codec: support WoV") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > changes in v2: > - update Fixes tag > v1 Link: https://lore.kernel.org/r/20220602114529.6303-1-linmq006@gmail.com > --- > sound/soc/codecs/cros_ec_codec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c > index 8b0a9c788a26..11e7b3f6d410 100644 > --- a/sound/soc/codecs/cros_ec_codec.c > +++ b/sound/soc/codecs/cros_ec_codec.c > @@ -995,6 +995,7 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev) > dev_dbg(dev, "ap_shm_phys_addr=%#llx len=%#x\n", > priv->ap_shm_phys_addr, priv->ap_shm_len); > } > + of_node_put(node); > } > #endif > > -- > 2.25.1 >
On Fri, Jun 03, 2022 at 05:10:43PM +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b6bc07d4360d ("ASoC: cros_ec_codec: support WoV") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
On Fri, 3 Jun 2022 17:10:43 +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cros_ec_codec: Fix refcount leak in cros_ec_codec_platform_probe commit: 0a034d93ee929a9ea89f3fa5f1d8492435b9ee6e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c index 8b0a9c788a26..11e7b3f6d410 100644 --- a/sound/soc/codecs/cros_ec_codec.c +++ b/sound/soc/codecs/cros_ec_codec.c @@ -995,6 +995,7 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev) dev_dbg(dev, "ap_shm_phys_addr=%#llx len=%#x\n", priv->ap_shm_phys_addr, priv->ap_shm_len); } + of_node_put(node); } #endif
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: b6bc07d4360d ("ASoC: cros_ec_codec: support WoV") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- changes in v2: - update Fixes tag v1 Link: https://lore.kernel.org/r/20220602114529.6303-1-linmq006@gmail.com --- sound/soc/codecs/cros_ec_codec.c | 1 + 1 file changed, 1 insertion(+)