| Message ID | 20220606014237.290466-1-chi.minghao@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | staging: wfx: Remove redundant NULL check before release_firmware() call | expand |
On Monday 6 June 2022 03:42:37 CEST cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > release_firmware() checks for NULL pointers internally so checking > before calling it is redundant. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/net/wireless/silabs/wfx/fwio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/silabs/wfx/fwio.c b/drivers/net/wireless/silabs/wfx/fwio.c > index 3d1b8a135dc0..52c7f560b062 100644 > --- a/drivers/net/wireless/silabs/wfx/fwio.c > +++ b/drivers/net/wireless/silabs/wfx/fwio.c > @@ -286,8 +286,7 @@ static int load_firmware_secure(struct wfx_dev *wdev) > > error: > kfree(buf); > - if (fw) > - release_firmware(fw); > + release_firmware(fw); > if (ret) > print_boot_status(wdev); > return ret; > -- > 2.25.1 Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Jérôme Pouiller <jerome.pouiller@silabs.com> writes: > On Monday 6 June 2022 03:42:37 CEST cgel.zte@gmail.com wrote: >> From: Minghao Chi <chi.minghao@zte.com.cn> >> >> release_firmware() checks for NULL pointers internally so checking >> before calling it is redundant. >> >> Reported-by: Zeal Robot <zealci@zte.com.cn> >> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> [...] > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> I'll change this to Acked-by, s-o-b should be used only when you are part of patch distribution: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by And please edit your quotes, otherwise using patchwork will be painful.
cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > release_firmware() checks for NULL pointers internally so checking > before calling it is redundant. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > Acked-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Patch applied to wireless-next.git, thanks. 05a2eebfa650 wifi: wfx: Remove redundant NULL check before release_firmware() call
diff --git a/drivers/net/wireless/silabs/wfx/fwio.c b/drivers/net/wireless/silabs/wfx/fwio.c index 3d1b8a135dc0..52c7f560b062 100644 --- a/drivers/net/wireless/silabs/wfx/fwio.c +++ b/drivers/net/wireless/silabs/wfx/fwio.c @@ -286,8 +286,7 @@ static int load_firmware_secure(struct wfx_dev *wdev) error: kfree(buf); - if (fw) - release_firmware(fw); + release_firmware(fw); if (ret) print_boot_status(wdev); return ret;