diff mbox series

ceph: call netfs_subreq_terminated with was_async == false

Message ID 20220607182218.234138-1-jlayton@kernel.org
State New
Headers show
Series ceph: call netfs_subreq_terminated with was_async == false | expand

Commit Message

Jeff Layton June 7, 2022, 6:22 p.m. UTC
"was_async" is a bit misleadingly named. It's supposed to indicate
whether it's safe to call blocking operations from the context you're
calling it from, but it sounds like it's asking whether this was done
via async operation. For ceph, this it's always called from kernel
thread context so it should be safe to set this to false.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ceph/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiubo Li June 11, 2022, 12:30 a.m. UTC | #1
On 6/8/22 2:22 AM, Jeff Layton wrote:
> "was_async" is a bit misleadingly named. It's supposed to indicate
> whether it's safe to call blocking operations from the context you're
> calling it from, but it sounds like it's asking whether this was done
> via async operation. For ceph, this it's always called from kernel
> thread context so it should be safe to set this to false.
>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>   fs/ceph/addr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 3489444c55b9..39e2c64d008f 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -241,7 +241,7 @@ static void finish_netfs_read(struct ceph_osd_request *req)
>   	if (err >= 0 && err < subreq->len)
>   		__set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags);
>   
> -	netfs_subreq_terminated(subreq, err, true);
> +	netfs_subreq_terminated(subreq, err, false);
>   
>   	num_pages = calc_pages_for(osd_data->alignment, osd_data->length);
>   	ceph_put_page_vector(osd_data->pages, num_pages, false);

Sorry, I think I missed this one.

LGTM. Thanks Jeff !

-- Xiubo
diff mbox series

Patch

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 3489444c55b9..39e2c64d008f 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -241,7 +241,7 @@  static void finish_netfs_read(struct ceph_osd_request *req)
 	if (err >= 0 && err < subreq->len)
 		__set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags);
 
-	netfs_subreq_terminated(subreq, err, true);
+	netfs_subreq_terminated(subreq, err, false);
 
 	num_pages = calc_pages_for(osd_data->alignment, osd_data->length);
 	ceph_put_page_vector(osd_data->pages, num_pages, false);